public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [uboot] [PATCH v5 2/7] net: zynq_gem: Add the passing of the phy-handle node
Date: Mon, 11 Apr 2016 15:05:50 +0200	[thread overview]
Message-ID: <570BA12E.8020506@xilinx.com> (raw)
In-Reply-To: <1460377108-19262-2-git-send-email-dmurphy@ti.com>

On 11.4.2016 14:18, Dan Murphy wrote:
> Add the ability to pass the phy-handle node offset
> to the phy driver.  This allows the phy driver
> to access the DT subnode's data and parse accordingly.
> 
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> 
> v5 - Removed unused variable and fixed checkpatch warning - https://patchwork.ozlabs.org/patch/608083/
> 
>  drivers/net/zynq_gem.c | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
> index aec8077..f9b22c4 100644
> --- a/drivers/net/zynq_gem.c
> +++ b/drivers/net/zynq_gem.c
> @@ -179,6 +179,7 @@ struct zynq_gem_priv {
>  	struct zynq_gem_regs *iobase;
>  	phy_interface_t interface;
>  	struct phy_device *phydev;
> +	int phy_of_handle;
>  	struct mii_dev *bus;
>  };
>  
> @@ -352,6 +353,10 @@ static int zynq_phy_init(struct udevice *dev)
>  	priv->phydev->supported = supported | ADVERTISED_Pause |
>  				  ADVERTISED_Asym_Pause;
>  	priv->phydev->advertising = priv->phydev->supported;
> +
> +	if (priv->phy_of_handle > 0)
> +		priv->phydev->dev->of_offset = priv->phy_of_handle;
> +
>  	phy_config(priv->phydev);
>  
>  	return 0;
> @@ -675,7 +680,6 @@ static int zynq_gem_ofdata_to_platdata(struct udevice *dev)
>  {
>  	struct eth_pdata *pdata = dev_get_platdata(dev);
>  	struct zynq_gem_priv *priv = dev_get_priv(dev);
> -	int offset = 0;
>  	const char *phy_mode;
>  
>  	pdata->iobase = (phys_addr_t)dev_get_addr(dev);
> @@ -684,10 +688,11 @@ static int zynq_gem_ofdata_to_platdata(struct udevice *dev)
>  	priv->emio = 0;
>  	priv->phyaddr = -1;
>  
> -	offset = fdtdec_lookup_phandle(gd->fdt_blob, dev->of_offset,
> -				       "phy-handle");
> -	if (offset > 0)
> -		priv->phyaddr = fdtdec_get_int(gd->fdt_blob, offset, "reg", -1);
> +	priv->phy_of_handle = fdtdec_lookup_phandle(gd->fdt_blob,
> +					dev->of_offset, "phy-handle");
> +	if (priv->phy_of_handle > 0)
> +		priv->phyaddr = fdtdec_get_int(gd->fdt_blob,
> +					priv->phy_of_handle, "reg", -1);
>  
>  	phy_mode = fdt_getprop(gd->fdt_blob, dev->of_offset, "phy-mode", NULL);
>  	if (phy_mode)
> 

Tested-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

  reply	other threads:[~2016-04-11 13:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-11 12:18 [U-Boot] [uboot] [PATCH v5 1/7] drivers: net: cpsw: Add reading of DT phy-handle node Dan Murphy
2016-04-11 12:18 ` [U-Boot] [uboot] [PATCH v5 2/7] net: zynq_gem: Add the passing of the " Dan Murphy
2016-04-11 13:05   ` Michal Simek [this message]
2016-04-13 13:37   ` Dan Murphy
2016-04-11 12:18 ` [U-Boot] [uboot] [PATCH v5 3/7] net: phy: dp83867: Add device tree bindings and documentation Dan Murphy
2016-04-13 13:37   ` Dan Murphy
2016-04-11 12:18 ` [U-Boot] [uboot] [PATCH v5 4/7] net: phy: ti: Allow the driver to be more configurable Dan Murphy
2016-04-11 13:06   ` Michal Simek
2016-04-13 13:37   ` Dan Murphy
2016-04-15 11:07   ` Mugunthan V N
2016-04-11 12:18 ` [U-Boot] [uboot] [PATCH v5 5/7] net: phy: Move is_rgmii helper to phy.h Dan Murphy
2016-04-11 13:06   ` Michal Simek
2016-04-13 13:37   ` Dan Murphy
2016-04-11 12:18 ` [U-Boot] [uboot] [PATCH v5 6/7] net: phy: Add phy_interface_is_sgmii " Dan Murphy
2016-04-13 13:38   ` Dan Murphy
2016-04-11 12:18 ` [U-Boot] [uboot] [PATCH v5 7/7] net: phy: dp83867: Add SGMII helper for configuration Dan Murphy
2016-04-13 13:38   ` Dan Murphy
2016-04-13 13:36 ` [U-Boot] [uboot] [PATCH v5 1/7] drivers: net: cpsw: Add reading of DT phy-handle node Dan Murphy
2016-04-15 10:53 ` Mugunthan V N
2016-04-15 11:03 ` Mugunthan V N

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570BA12E.8020506@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox