[U-Boot] [PATCH] cmd: fdt: Use separate CMD_FDT Kconfig entry instead of OF_LIBFDT

Simon Glass
2016-04-05T19:09:58Z

Hi Michal,

On 5 April 2016 at 04:15, Michal Simek <michal.simek@xilinx.com> wrote:
> Hi Simon,
>
> On 5.4.2016 02:03, Simon Glass wrote:
>> Hi Michal,
>>
>> On 4 April 2016 at 11:50, Michal Simek <michal.simek@xilinx.com> wrote:
>>> Create CMD_FDT Kconfig entry to have an option to disable fdt command
>>> which is not required for small configuration which requires libfdt
>>> only.
>>> Enable it by default for all targets which enables OF_LIBFDT.
>>>
>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>> ---
>>>
>>> cmd/Kconfig | 7 +++++++
>>> cmd/Makefile | 2 +-
>>> 2 files changed, 8 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/cmd/Kconfig b/cmd/Kconfig
>>> index fe8b4f0510da..8703cdb4a9be 100644
>>> --- a/cmd/Kconfig
>>> +++ b/cmd/Kconfig
>>> @@ -173,6 +173,13 @@ config CMD_ELF
>>> help
>>> Boot an ELF/vxWorks image from the memory.
>>>
>>> +config CMD_FDT
>>> + bool "Flattened Device Tree utility commands"
>>> + default y
>>
>> Should that be:
>>
>> default y if OF_LIBFDT
>>
>> ?
>>
>>> + depends on OF_LIBFDT
>>> + help
>>> + Do FDT related setup before booting into the Operating System.
>>> +
>
>
> In recent commits to this file both formats are used.
>
> +config CMD_BLOCK_CACHE
> + bool "blkcache - control and stats for block cache"
> + depends on BLOCK_CACHE
> + default y if BLOCK_CACHE
>
> even looks non standard.
>
> +config CMD_BOOTEFI
> + bool "bootefi"
> + depends on EFI_LOADER
> + default y
>
> I am happy to change whatever style you prefer but I think it should be
> synchronized. The efi one was Reviewed by you. :-)

I think Masahiro knows most about this. If it works it's fine with me.
The way you have it is more intuitive and I prefer it. But he did
point at a problem at some point.

One other question - won't this disable the 'fdt' command for many boards?

Regards,
Simon