From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 12 Apr 2016 14:04:17 -0600 Subject: [U-Boot] [PATCH 09/44] dm: scsi: Remove the forward declarations In-Reply-To: <1460256336-30436-10-git-send-email-sjg@chromium.org> References: <1460256336-30436-1-git-send-email-sjg@chromium.org> <1460256336-30436-10-git-send-email-sjg@chromium.org> Message-ID: <570D54C1.8000007@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/09/2016 08:45 PM, Simon Glass wrote: > Reorder the code to avoid needing forward declarations. > diff --git a/cmd/scsi.c b/cmd/scsi.c > @@ -50,6 +50,7 @@ static int scsi_curr_dev; /* current device */ > > static struct blk_desc scsi_dev_desc[CONFIG_SYS_SCSI_MAX_DEVICE]; > > +#if 0 > /******************************************************************************** > * forward declerations of some Setup Routines > */ > @@ -70,110 +71,232 @@ static ulong scsi_read(struct blk_desc *block_dev, lbaint_t blknr, > lbaint_t blkcnt, void *buffer); > static ulong scsi_write(struct blk_desc *block_dev, lbaint_t blknr, > lbaint_t blkcnt, const void *buffer); > +#endif I assume that should all be deleted; it was just #if 0 for testing this change?