From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 12 Apr 2016 14:31:20 -0600 Subject: [U-Boot] [PATCH 16/44] dm: systemace: Add a legacy block interface In-Reply-To: <1460256336-30436-17-git-send-email-sjg@chromium.org> References: <1460256336-30436-1-git-send-email-sjg@chromium.org> <1460256336-30436-17-git-send-email-sjg@chromium.org> Message-ID: <570D5B18.8000604@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/09/2016 08:45 PM, Simon Glass wrote: > Add a legacy block interface for systemace. > diff --git a/drivers/block/systemace.c b/drivers/block/systemace.c > +static int systemace_get_devp(int dev, struct blk_desc **descp) I'm not sure what "devp" means here rather than "dev". I suppose it's to avoid a naming conflict with an existing identically named function. Perhaps s/get_devp/get_dev_legacy/ since it's part of the legacy block device API? Actually, it looks like this name is temporary and thrown away later, so it's probably not worth fixing.