From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Tue, 12 Apr 2016 14:49:29 -0600
Subject: [U-Boot] [PATCH 34/44] dm: ide: Add support for driver-model
 block devices
In-Reply-To: <1460256336-30436-35-git-send-email-sjg@chromium.org>
References: <1460256336-30436-1-git-send-email-sjg@chromium.org>
 <1460256336-30436-35-git-send-email-sjg@chromium.org>
Message-ID: <570D5F59.8060109@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 04/09/2016 08:45 PM, Simon Glass wrote:
> Add driver-model block-device support to the IDE implementation.

> diff --git a/include/ide.h b/include/ide.h

> +struct udevice;
> +#ifdef CONFIG_BLK
> +ulong ide_read(struct udevice *dev, lbaint_t blknr, lbaint_t blkcnt,
> +	       void *buffer);
> +ulong ide_write(struct udevice *dev, lbaint_t blknr, lbaint_t blkcnt,
> +		const void *buffer);
> +#else
>   ulong ide_read(struct blk_desc *block_dev, lbaint_t blknr, lbaint_t blkcnt,
>   	       void *buffer);
>   ulong ide_write(struct blk_desc *block_dev, lbaint_t blknr, lbaint_t blkcnt,
>   		const void *buffer);
> +#endif

Does anything outside of the IDE code itself rely on these prototypes 
when CONFIG_BLK is enabled? I'd hope to see #ifndef CONFIG_BLK added, 
without an actual prototype since the function itself should be static 
once IDE is converted to CONFIG_BLK?