[U-Boot] [PATCH 16/44] dm: systemace: Add a legacy block interface

Simon Glass
2016-05-01T18:56:37Z

Hi Stephen,

On 12 April 2016 at 14:31, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 04/09/2016 08:45 PM, Simon Glass wrote:
>>
>> Add a legacy block interface for systemace.
>
>
>> diff --git a/drivers/block/systemace.c b/drivers/block/systemace.c
>
>
>> +static int systemace_get_devp(int dev, struct blk_desc **descp)
>
>
> I'm not sure what "devp" means here rather than "dev". I suppose it's to
> avoid a naming conflict with an existing identically named function. Perhaps
> s/get_devp/get_dev_legacy/ since it's part of the legacy block device API?
>
> Actually, it looks like this name is temporary and thrown away later, so
> it's probably not worth fixing.

Yes that's right. It is temporary.

Regards,
Simon