public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] efi_loader: Handle memory overflows
Date: Wed, 13 Apr 2016 14:07:17 +0200	[thread overview]
Message-ID: <570E3675.9050309@suse.de> (raw)
In-Reply-To: <1460549078-23382-1-git-send-email-afaerber@suse.de>

On 04/13/2016 02:04 PM, Andreas F?rber wrote:
> jetson-tk1 has 2 GB of RAM at 0x80000000, causing gd->ram_top to be zero.
> Handle this by either avoiding ram_top or by using the same type as
> ram_top to reverse the overflow effect.
>
> Cc: Alexander Graf <agraf@suse.de>
> Signed-off-by: Andreas F?rber <afaerber@suse.de>

Reviewed-by: Alexander Graf <agraf@suse.de>


Alex

> ---
>   lib/efi_loader/efi_memory.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c
> index 138736f..82003d7 100644
> --- a/lib/efi_loader/efi_memory.c
> +++ b/lib/efi_loader/efi_memory.c
> @@ -225,7 +225,7 @@ efi_status_t efi_allocate_pages(int type, int memory_type,
>   	switch (type) {
>   	case 0:
>   		/* Any page */
> -		addr = efi_find_free_memory(len, gd->ram_top);
> +		addr = efi_find_free_memory(len, gd->start_addr_sp);
>   		if (!addr) {
>   			r = EFI_NOT_FOUND;
>   			break;
> @@ -325,9 +325,9 @@ efi_status_t efi_get_memory_map(unsigned long *memory_map_size,
>   
>   int efi_memory_init(void)
>   {
> -	uint64_t runtime_start, runtime_end, runtime_pages;
> -	uint64_t uboot_start, uboot_pages;
> -	uint64_t uboot_stack_size = 16 * 1024 * 1024;
> +	unsigned long runtime_start, runtime_end, runtime_pages;
> +	unsigned long uboot_start, uboot_pages;
> +	unsigned long uboot_stack_size = 16 * 1024 * 1024;
>   	int i;
>   
>   	/* Add RAM */

  reply	other threads:[~2016-04-13 12:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13 12:04 [U-Boot] [PATCH v2] efi_loader: Handle memory overflows Andreas Färber
2016-04-13 12:07 ` Alexander Graf [this message]
2016-04-21 11:24 ` [U-Boot] [U-Boot,v2] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570E3675.9050309@suse.de \
    --to=agraf@suse.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox