From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 14 Apr 2016 00:03:23 +0200 Subject: [U-Boot] [PATCH] arm: socfpga: clean up common config options In-Reply-To: <570E825A.2080806@denx.de> References: <1460561696-8100-1-git-send-email-dinguyen@opensource.altera.com> <570E825A.2080806@denx.de> Message-ID: <570EC22B.5020205@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/13/2016 07:31 PM, Stefan Roese wrote: > On 13.04.2016 17:34, dinguyen at opensource.altera.com wrote: >> From: Dinh Nguyen >> >> Move common config options like these to socfpga_common.h: >> >> CONFIG_SYS_NO_FLASH >> CONFIG_DOS_PARTITION >> CONFIG_FAT_WRITE >> CONFIG_HW_WATCHDOG >> >> CONFIG_CMD_ASKENV >> CONFIG_CMD_BOOTZ >> CONFIG_CMD_CACHE >> CONFIG_CMD_DHCP >> CONFIG_CMD_EXT4 >> CONFIG_CMD_EXT4_WRITE >> CONFIG_CMD_FAT >> CONFIG_CMD_FS_GENERIC >> CONFIG_CMD_GREPENV >> CONFIG_CMD_MEMTEST >> CONFIG_CMD_MII >> CONFIG_CMD_MMC >> CONFIG_CMD_PING >> CONFIG_CMD_SF >> CONFIG_CMD_SPI >> CONFIG_CMD_TIME >> >> to avoid defining them in individual SoCFPGA config files. >> >> Also to avoid a build error, move CONFIG_CMD_GPIO that was in >> socfpga_sr1500.h to socfpga_sr1500_defconfig. >> >> Signed-off-by: Dinh Nguyen > > Acked-by: Stefan Roese The reason why these configs were not in socfpga_common.h was to let boards configure which commands they will include, but I am fine with this patch too. Would you be interested in sending replacement patch , which moves these configs to Kconfig instead and move the config options to configs/socfpga*defconfig ? It would be helpful, but if not, I will just pick this one. -- Best regards, Marek Vasut