From: "Andreas Färber" <afaerber@suse.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mmc: add mmc partconf read capability
Date: Thu, 14 Apr 2016 18:59:09 +0200 [thread overview]
Message-ID: <570FCC5D.8030000@suse.de> (raw)
In-Reply-To: <570FCBBA.90107@sysam.it>
Am 14.04.2016 um 18:56 schrieb Angelo Dureghello:
> On 14/04/2016 01:16, Marek Vasut wrote:
>> On 04/14/2016 01:11 AM, Angelo Dureghello wrote:
>>> diff --git a/include/mmc.h b/include/mmc.h
>>> index cdb56e7..4b34b31 100644
>>> --- a/include/mmc.h
>>> +++ b/include/mmc.h
>>> @@ -222,6 +222,10 @@
>>> #define EXT_CSD_BOOT_PART_NUM(x) (x << 3)
>>> #define EXT_CSD_PARTITION_ACCESS(x) (x << 0)
>>>
>>> +#define EXT_CSD_EXTRACT_BOOT_ACK(x) ((x >> 6) & 1)
>>
>> Should be (((x) >> 6) & 1) , notice the parenthesis around x.
>>
>
> Ok
FTR I had reviewed your use cases and they looked okay, but Marek is
right that parenthesis are safer in such expressions.
Cheers,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
prev parent reply other threads:[~2016-04-14 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 23:11 [U-Boot] [PATCH v2] mmc: add mmc partconf read capability Angelo Dureghello
2016-04-13 23:16 ` Marek Vasut
2016-04-14 16:56 ` Angelo Dureghello
2016-04-14 16:59 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570FCC5D.8030000@suse.de \
--to=afaerber@suse.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox