From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Date: Thu, 14 Apr 2016 18:59:09 +0200 Subject: [U-Boot] [PATCH v2] mmc: add mmc partconf read capability In-Reply-To: <570FCBBA.90107@sysam.it> References: <1460589100-23968-1-git-send-email-angelo@sysam.it> <570ED332.2020209@denx.de> <570FCBBA.90107@sysam.it> Message-ID: <570FCC5D.8030000@suse.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am 14.04.2016 um 18:56 schrieb Angelo Dureghello: > On 14/04/2016 01:16, Marek Vasut wrote: >> On 04/14/2016 01:11 AM, Angelo Dureghello wrote: >>> diff --git a/include/mmc.h b/include/mmc.h >>> index cdb56e7..4b34b31 100644 >>> --- a/include/mmc.h >>> +++ b/include/mmc.h >>> @@ -222,6 +222,10 @@ >>> #define EXT_CSD_BOOT_PART_NUM(x) (x << 3) >>> #define EXT_CSD_PARTITION_ACCESS(x) (x << 0) >>> >>> +#define EXT_CSD_EXTRACT_BOOT_ACK(x) ((x >> 6) & 1) >> >> Should be (((x) >> 6) & 1) , notice the parenthesis around x. >> > > Ok FTR I had reviewed your use cases and they looked okay, but Marek is right that parenthesis are safer in such expressions. Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg)