[U-Boot] [PATCH] mips: fix DTC unit warnings

Purna Chandra Mandal
2016-04-18T12:48:47Z

On 04/15/2016 08:53 PM, Andreas F?rber wrote:

> Am 15.04.2016 um 12:59 schrieb Heiko Schocher:
>> Fix following warnings for all mips based boards:
>> mips: + pic32mzdask
>> +Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
>> +Warning (unit_address_vs_reg): Node /cpus/cpu at 0 has a unit name, but no reg property
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> ---
>> This warnings pop up with the DTC compiler:
>> $ /tmp/dtc/dtc -v
>> Version: DTC 1.4.1-gbeef80b8
>>
>> This fixes the compile warnings for:
>> https://travis-ci.org/hsdenx/u-boot/jobs/123254184
>>
>> see:
>> https://travis-ci.org/hsdenx/u-boot/jobs/123281033
>>
>>
>> arch/mips/dts/pic32mzda.dtsi | 2 +-
>> arch/mips/dts/skeleton.dtsi | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/mips/dts/pic32mzda.dtsi b/arch/mips/dts/pic32mzda.dtsi
>> index 8a554f9..791c364 100644
>> --- a/arch/mips/dts/pic32mzda.dtsi
>> +++ b/arch/mips/dts/pic32mzda.dtsi
>> @@ -27,7 +27,7 @@
>> };
>>
>> cpus {
>> - cpu at 0 {
>> + cpu {
>> compatible = "mips,mips14kc";
>> };
>> };
>> diff --git a/arch/mips/dts/skeleton.dtsi b/arch/mips/dts/skeleton.dtsi
>> index 24ee6c3..643996c 100644
>> --- a/arch/mips/dts/skeleton.dtsi
>> +++ b/arch/mips/dts/skeleton.dtsi
>> @@ -16,7 +16,7 @@
>> aliases {
>> };
>>
>> - memory {
>> + memory at 0 {
> I have just been told on linux-rockchip mailing list that such a change
> should not be done as /memory is being special-cased in dtc warnings for
> the benefit of U-Boot. Supposedly U-Boot cannot handle updating memory
> size on /memory at 0.
>
> If that is untrue, please someone object on the Linux mailing lists.

Interestingly MIPS arch does not update size on /memory node during bootm.
Either we can fix that in arch/mips/ or all boards have to implement board
specific ft_board_setup() to address this. Shortly you'll see a patch.

In PIC32 boards(may be in some other boards as well) embedded dts is used
for U-Boot and for Linux full dts is downloaded from external media. And
external version has updated memory reg=<> property so problem due to
'/memory at 0' fix is not seen.

>
> Regards,
> Andreas
>
>> device_type = "memory";
>> reg = <0 0>;
>> };