public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Angelo Dureghello <angelo@sysam.it>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] m68k: add malloc memory for early malloc
Date: Fri, 15 Apr 2016 16:42:03 +0200	[thread overview]
Message-ID: <5710FDBB.2020005@sysam.it> (raw)
In-Reply-To: <CAPnjgZ1QiSejUmpr+naJmZj5bQJgKH7pno57JvcVxJ6Fr955=A@mail.gmail.com>

Hi Simon,

On 15/04/2016 16:14, Simon Glass wrote:
> Hi Angelo,
>
> On 27 December 2015 at 21:22, Simon Glass <sjg@chromium.org> wrote:
>> On 20 December 2015 at 08:54, Angelo Dureghello <angelo@sysam.it> wrote:
>>> To use serial uclass and DM, CONFIG_SYS_MALLOC_F must be used.
>>> So CONFIG_SYS_GENERIC_GLOBAL_DATA has been undefined and
>>> call to board_init_f_mem() is added for all cpu's.
>>>
>>> Signed-off-by: Angelo Dureghello <angelo@sysam.it>
>>>
>>> ---
>>>
>>> Changes in v2: None
>>>
>>>   arch/m68k/cpu/mcf5227x/start.S   | 8 ++++++++
>>>   arch/m68k/cpu/mcf523x/start.S    | 8 ++++++++
>>>   arch/m68k/cpu/mcf52x2/start.S    | 8 ++++++++
>>>   arch/m68k/cpu/mcf530x/cpu_init.c | 2 +-
>>>   arch/m68k/cpu/mcf530x/start.S    | 8 ++++++++
>>>   arch/m68k/cpu/mcf532x/start.S    | 8 ++++++++
>>>   arch/m68k/cpu/mcf5445x/start.S   | 8 ++++++++
>>>   arch/m68k/cpu/mcf547x_8x/start.S | 8 ++++++++
>>>   arch/m68k/include/asm/config.h   | 2 --
>>>   9 files changed, 57 insertions(+), 3 deletions(-)
>>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> Unfortunately this breaks a lot of boards so I cannot apply it:
>
> 22: m68k: add malloc memory for early malloc
>        m68k:  +   M5475FFE M5475GFE M5485AFE M5475BFE M52277EVB
> M5485FFE M54451EVB M54418TWR_nand_rmii M54418TWR_serial_mii M5475EFE
> M5485CFE M54451EVB_stmicro M5485BFE M5485HFE M54418TWR_serial_rmii
> M5475DFE M52277EVB_stmicro M5475AFE M5485GFE M54418TWR_nand_mii
> eb_cpu5282_internal amcore M53017EVB M54418TWR_nand_rmii_lowfreq
> M54418TWR M5475CFE M5485EFE M5485DFE eb_cpu5282
> +arch/m68k/cpu/mcf547x_8x/start.o: In function `_start':
> +build/../arch/m68k/cpu/mcf547x_8x/start.S:153: undefined reference to
> `board_init_f_mem'
> +build/../arch/m68k/cpu/mcf547x_8x/start.S:153:(.text+0x470):
> relocation truncated to fit: R_68K_PC16 against undefined symbol
> `board_init_f_mem'
> +make[1]: *** [u-boot] Error 1
> +make: *** [sub-make] Error 2
> +arch/m68k/cpu/mcf5227x/start.o: In function `_start':
> +build/../arch/m68k/cpu/mcf5227x/start.S:384: undefined reference to
> `board_init_f_mem'
> +arch/m68k/cpu/mcf5445x/start.o: In function `_start':
> +build/../arch/m68k/cpu/mcf5445x/start.S:669: undefined reference to
> `board_init_f_mem'
> +build/../arch/m68k/cpu/mcf5445x/start.S:669:(.text+0x41c): relocation
> truncated to fit: R_68K_PC16 against undefined symbol
> `board_init_f_mem'
> +build/../arch/m68k/cpu/mcf5227x/start.S:384:(.text+0x44a): relocation
> truncated to fit: R_68K_PC16 against undefined symbol
> `board_init_f_mem'
> +arch/m68k/cpu/mcf52x2/start.o: In function `_after_flashbar_copy':
> +build/../arch/m68k/cpu/mcf52x2/start.S:203: undefined reference to
> `board_init_f_mem'
> +build/../arch/m68k/cpu/mcf52x2/start.S:203:(.text+0x494): relocation
> truncated to fit: R_68K_PC16 against undefined symbol
> `board_init_f_mem'
> +arch/m68k/cpu/mcf530x/start.o: In function `_start':
> +build/../arch/m68k/cpu/mcf530x/start.S:142: undefined reference to
> `board_init_f_mem'
> +build/../arch/m68k/cpu/mcf530x/start.S:142:(.text+0x45e): relocation
> truncated to fit: R_68K_PC16 against undefined symbol
> `board_init_f_mem'
> +arch/m68k/cpu/mcf532x/start.o: In function `_start':
> +build/../arch/m68k/cpu/mcf532x/start.S:160: undefined reference to
> `board_init_f_mem'
> +arch/m68k/cpu/mcf52x2/start.o: In function `_start':
> +build/../arch/m68k/cpu/mcf52x2/start.S:203:(.text+0x456): relocation
> truncated to fit: R_68K_PC16 against undefined symbol
> `board_init_f_mem'
>

Issue was not there at that submit time, now it seems due to growing of 
u-boot size.

The "truncated to fit" issue is fixed with this patch.

https://patchwork.ozlabs.org/patch/609150/

So if you apply the above, and then this current, all should work.

Regards,
Angelo


> Regards,
> Simon
>

  reply	other threads:[~2016-04-15 14:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-20 15:54 [U-Boot] [PATCH v2 1/2] m68k: add malloc memory for early malloc Angelo Dureghello
2015-12-20 15:54 ` [U-Boot] [PATCH v2 2/2] m68k: add DM model serial driver Angelo Dureghello
2015-12-28  4:22   ` Simon Glass
2015-12-28  4:22 ` [U-Boot] [PATCH v2 1/2] m68k: add malloc memory for early malloc Simon Glass
2016-04-15 14:14   ` Simon Glass
2016-04-15 14:42     ` Angelo Dureghello [this message]
2016-04-15 15:23       ` Simon Glass
2016-04-15 16:38         ` Angelo Dureghello
2016-04-22 18:33           ` Simon Glass
2016-04-22 22:02             ` Angelo Dureghello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5710FDBB.2020005@sysam.it \
    --to=angelo@sysam.it \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox