From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB105C4338F for ; Thu, 19 Aug 2021 11:36:05 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 117AF60F11 for ; Thu, 19 Aug 2021 11:36:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 117AF60F11 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7EA7082EBB; Thu, 19 Aug 2021 13:36:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1629372963; bh=0iJ/bAnuvkzqC6sZX95dTQmHrzkIt6WdAwcidS/tlRg=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=iVLMii57Fe4cZgO3JJAssJt1wAX8MlwGEalq7GLRZiXXoPIIfGJ/pV6QFCwkAcUSU q1Rxa9Kv3akPjQEIA7QGSKiG2+9AvPaV7d4BBZRihyUGdfWBls+jQSBX8JgwGf4HX9 HWog+EVxNg3fH9iYWRso3+aFLNHKO2i4W0xCBmwzYIZVcCuSYEV8myPbCpaHA2gLGR TGmqcYYtmrdzW5+3f51oFV0JKI6XaEvCPax4oL9xtS99zriG6KCN+FkF7dhyU61xoZ zAEZk4ZQZnguY8axYoSpAGeDLbBx15EU05YCC9c2L8mTNdU4kU8e/2XjdQrikQZGfQ 6UzG7fTi9lF2Q== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id D23DB82E67 for ; Thu, 19 Aug 2021 13:36:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1629372960; bh=0iJ/bAnuvkzqC6sZX95dTQmHrzkIt6WdAwcidS/tlRg=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=Sgyup2w5yRSeZC2CtYGDP34u+K5hOUkq4w8OGU3QSTLwb4s6s6BxT1xIXWfSTISss peNaUh0sLEuKFcGcuHpLrWguuuWLEYxjMfXibhWAgqa6ncerfusyN7wFpzGxBF1Npw sOMEe25nbr/3930Q7RdhaP3quu/xte9WD3FZ5qX1PABf/Io0JTfdEV33DL64STX1yh adoG5TavyMBN+ezP/zI6rc+NHqOSfHK06CtegRc7sb+QQXlTvVA4bkZzu26BvSQzEQ a08hDMH3K5hK7CTjxqrJjO4EcWcDoV65YAu3TxsfbJjQy6Jr+D2MTztt7Se6wBgz4u ifZm9/W9N4hNQ== Received: by janitor.denx.de (Postfix, from userid 108) id 76E55A0156; Thu, 19 Aug 2021 13:36:00 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 7E344A0060; Thu, 19 Aug 2021 13:35:50 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 408701E1772; Thu, 19 Aug 2021 13:35:50 +0200 (CEST) To: Rasmus Villemoes cc: u-boot@lists.denx.de, Simon Glass , Stefan Roese , Tom Rini From: Wolfgang Denk Subject: Re: [PATCH v6 05/12] watchdog: wdt-uclass.c: keep track of each device's running state MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20210819095706.3585923-6-rasmus.villemoes@prevas.dk> References: <20210819095706.3585923-1-rasmus.villemoes@prevas.dk> <20210819095706.3585923-6-rasmus.villemoes@prevas.dk> Comments: In-reply-to Rasmus Villemoes message dated "Thu, 19 Aug 2021 11:56:59 +0200." Date: Thu, 19 Aug 2021 13:35:50 +0200 Message-ID: <57131.1629372950@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Rasmus, please check your patches for proper error handling. In message <20210819095706.3585923-6-rasmus.villemoes@prevas.dk> you wrote: > ... > diff --git a/drivers/watchdog/wdt-uclass.c b/drivers/watchdog/wdt-uclass.c > index 0a1f43771c..358fc68e27 100644 > --- a/drivers/watchdog/wdt-uclass.c > +++ b/drivers/watchdog/wdt-uclass.c ... > @@ -86,8 +89,11 @@ int wdt_start(struct udevice *dev, u64 timeout_ms, ulong flags) > return -ENOSYS; > > ret = ops->start(dev, timeout_ms, flags); > - if (ret == 0) > - gd->flags |= GD_FLG_WDT_READY; > + if (ret == 0) { > + struct wdt_priv *priv = dev_get_uclass_priv(dev); > + > + priv->running = true; dev_get_uclass_priv() can return NULL, in which case you would be dereferencing a NULL pointer... > @@ -101,8 +107,11 @@ int wdt_stop(struct udevice *dev) > return -ENOSYS; > > ret = ops->stop(dev); > - if (ret == 0) > - gd->flags &= ~GD_FLG_WDT_READY; > + if (ret == 0) { > + struct wdt_priv *priv = dev_get_uclass_priv(dev); > + > + priv->running = false; Same here. > @@ -156,6 +165,9 @@ void watchdog_reset(void) > > dev = gd->watchdog_dev; > priv = dev_get_uclass_priv(dev); > + if (!priv->running) > + return; > + And here again. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de I used to be indecisive, now I'm not sure.