From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sun, 17 Apr 2016 23:00:09 +0200 Subject: [U-Boot] [PATCH 00/12] Introduce layout aware eeprom commands In-Reply-To: <20160417103336.GA30053@skynet> References: <1460818513-24895-1-git-send-email-nikita@compulab.co.il> <57135BAB.4070400@denx.de> <20160417103336.GA30053@skynet> Message-ID: <5713F959.4030709@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/17/2016 12:33 PM, Nikita Kiryanov wrote: > Hi Marek, > > On Sun, Apr 17, 2016 at 11:47:23AM +0200, Marek Vasut wrote: >> On 04/16/2016 04:55 PM, Nikita Kiryanov wrote: >>> This series introduces eeprom layout aware capabilities to the existing eeprom >>> command, and then enables this feature on Compulab boards. It is an import of >>> the Compulab eeprom-utility (https://github.com/compulab/eeprom-util), and it >>> introduces 2 new options to the eeprom command: >>> >>> eeprom print [-l ] bus_num device_addr >> >> The bus number starts to become a problem, esp. when used with DM and >> where the bus number can change between boots. > > Are you referring to the fact that the command allows the user to not specify > the bus number (relying on a default value instead)? No, just using the bus number and device address doesn't seem right anymore. > If so, I agree with you > that it is problematic. If I had my way I would've made it a mendatory > parameter along with the device address, but that will hurt backwards > compatibility. But this is new feature, there is no backward compatibility. > I'll be more than happy to redo the last 3 patches if we > agree that we are willing to pay that price. > >> >> Best regards, >> Marek Vasut >> -- Best regards, Marek Vasut