public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: dts: socfpga: fix DTC unit name warnings
Date: Mon, 18 Apr 2016 13:06:35 +0200	[thread overview]
Message-ID: <5714BFBB.6000601@denx.de> (raw)
In-Reply-To: <20160418100051.GA26501@amd>

Hello Pavel,

Am 18.04.2016 um 12:00 schrieb Pavel Machek:
> Hi!
>
>>> Hi!
>>>
>>>> Warning (unit_address_vs_reg): Node /soc/usbphy at 0 has a unit name,
>>>>   but no reg property
>>>
>>> I don't know who produces the warnings, but perhaps fix the tool,
>>> instead?
>>
>> This warnigns poping up with new DTC compilers, introduced from dtc
>> commit:
>
> IMO compiler should be fixed.

A simple revert of this commit fixes it ... yes, but, see below.

>>      ePAPR 1.1 section 2.2.1.1 "Node Name Requirements" specifies
>> that any
>
> This is arm. This is not powerpc. It is 2016, not 1997.

Hmm...

>>>> -		usbphy0: usbphy at 0 {
>>>> +		usbphy0: usbphy {
>>>>   			#phy-cells = <0>;
>>>>   			compatible = "usb-nop-xceiv";
>>>>   			status = "okay";
>>>
>>> And this sounds like a bug waiting to happen..
>>
>> Better fix would be to add the reg property .. could you help me?
>
> Introduce fake "reg" property to shut up warning?

or fix "usbphy at 0" to "usbphy0".

> I guess this should be solved on the kernel list, and I believe the
> warnings are wrong.

I think it is discussed on the kernel mailinglist, see for example:

http://permalink.gmane.org/gmane.comp.devicetree.compiler/432

Nice here the comment from rob:
"Any objections to this series will result in getting added as a DT
binding maintainer. :)"

So, feel free to speak up!

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  parent reply	other threads:[~2016-04-18 11:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-15 10:41 [U-Boot] [PATCH] arm: dts: socfpga: fix DTC unit name warnings Heiko Schocher
2016-04-15 14:18 ` Marek Vasut
2016-04-18  4:55   ` Heiko Schocher
2016-04-18 10:36     ` Marek Vasut
2016-04-18 11:20       ` Heiko Schocher
2016-04-18 11:22         ` Marek Vasut
2016-04-17 21:55 ` Pavel Machek
2016-04-18  6:07   ` Heiko Schocher
2016-04-18 10:00     ` Pavel Machek
2016-04-18 10:35       ` Marek Vasut
2016-04-18 11:06       ` Heiko Schocher [this message]
2016-04-18 15:31 ` Tom Rini
2016-04-18 15:37   ` Marek Vasut
2016-04-18 15:46     ` Tom Rini
2016-04-18 17:52       ` Marek Vasut
2016-04-19  5:01         ` Heiko Schocher
2016-04-19 10:38           ` Marek Vasut
2016-04-19  4:47       ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5714BFBB.6000601@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox