[U-Boot] [PATCH] arm: dts: socfpga: fix DTC unit name warnings

Heiko Schocher
2016-04-18T11:20:52Z

Hello Marek,

Am 18.04.2016 um 12:36 schrieb Marek Vasut:
> On 04/18/2016 06:55 AM, Heiko Schocher wrote:
>> Hello Marek,
>>
>> Am 15.04.2016 um 16:18 schrieb Marek Vasut:
>>> On 04/15/2016 12:41 PM, Heiko Schocher wrote:
>>>> Fix following DTC warnings for all socfpga boards:
>>>> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
>>>> property, but no unit name
>>>> Warning (unit_address_vs_reg): Node
>>>> /soc/clkmgr at ffd04000/clocks/main_pll has a reg or ranges property,
>>>> but no unit name
>>>> Warning (unit_address_vs_reg): Node
>>>> /soc/clkmgr at ffd04000/clocks/main_pll/mpuclk has a reg or ranges
>>>> property, but no unit name
>>>> Warning (unit_address_vs_reg): Node
>>>> /soc/clkmgr at ffd04000/clocks/main_pll/mainclk has a reg or ranges
>>>> property, but no unit name
>>>> Warning (unit_address_vs_reg): Node
>>>> /soc/clkmgr at ffd04000/clocks/main_pll/dbg_base_clk has a reg or ranges
>>>> property, but no unit name
>>>> Warning (unit_address_vs_reg): Node
>>>> /soc/clkmgr at ffd04000/clocks/main_pll/main_qspi_clk has a reg or
>>>> ranges property, but no unit name
>>>> Warning (unit_address_vs_reg): Node
>>>> /soc/clkmgr at ffd04000/clocks/main_pll/main_nand_sdmmc_clk has a reg or
>>>> ranges property, but no unit name
>>>> Warning (unit_address_vs_reg): Node
>>>> /soc/clkmgr at ffd04000/clocks/main_pll/cfg_h2f_usr0_clk has a reg or
>>>> ranges property, but no unit name
>>>> Warning (unit_address_vs_reg): Node
>>>> /soc/clkmgr at ffd04000/clocks/periph_pll has a reg or ranges property,
>>>> but no unit name
>>>> Warning (unit_address_vs_reg): Node
>>>> /soc/clkmgr at ffd04000/clocks/periph_pll/emac0_clk has a reg or ranges
>>>> property, but no unit name
>>>> Warning (unit_address_vs_reg): Node
>>>> /soc/clkmgr at ffd04000/clocks/periph_pll/emac1_clk has a reg or ranges
>>>> property, but no unit name
>>>> Warning (unit_address_vs_reg): Node
>>>> /soc/clkmgr at ffd04000/clocks/periph_pll/per_qsi_clk has a reg or
>>>> ranges property, but no unit name
>>>> Warning (unit_address_vs_reg): Node
>>>> /soc/clkmgr at ffd04000/clocks/periph_pll/per_nand_mmc_clk has a reg or
>>>> ranges property, but no unit name
>>>> Warning (unit_address_vs_reg): Node
>>>> /soc/clkmgr at ffd04000/clocks/periph_pll/per_base_clk has a reg or
>>>> ranges property, but no unit name
>>>> Warning (unit_address_vs_reg): Node
>>>> /soc/clkmgr at ffd04000/clocks/periph_pll/h2f_usr1_clk has a reg or
>>>> ranges property, but no unit name
>>>> Warning (unit_address_vs_reg): Node
>>>> /soc/clkmgr at ffd04000/clocks/sdram_pll has a reg or ranges property,
>>>> but no unit name
>>>> Warning (unit_address_vs_reg): Node
>>>> /soc/clkmgr at ffd04000/clocks/sdram_pll/ddr_dqs_clk has a reg or ranges
>>>> property, but no unit name
>>>> Warning (unit_address_vs_reg): Node
>>>> /soc/clkmgr at ffd04000/clocks/sdram_pll/ddr_2x_dqs_clk has a reg or
>>>> ranges property, but no unit name
>>>> Warning (unit_address_vs_reg): Node
>>>> /soc/clkmgr at ffd04000/clocks/sdram_pll/ddr_dq_clk has a reg or ranges
>>>> property, but no unit name
>>>> Warning (unit_address_vs_reg): Node
>>>> /soc/clkmgr at ffd04000/clocks/sdram_pll/h2f_usr2_clk has a reg or
>>>> ranges property, but no unit name
>>>> Warning (unit_address_vs_reg): Node /soc/usbphy at 0 has a unit name,
>>>> but no reg property
>>>
>>> How come Linux isn't affected by this ?
>>
>> I think linux is also affected!
>
> You might want to bring it up on the LKML, like Pavel suggested.

Do we have the same DTS as linux?
(If so, isn;t it a bad idea to hold the files on 2 places?)

bye,
Heiko
>
>>>> Signed-off-by: Heiko Schocher <hs@denx.de>
>>>> ---
>>>> This warnings pop up with the DTC compiler:
>>>> $ /tmp/dtc/dtc -v
>>>> Version: DTC 1.4.1-gbeef80b8
>>>>
>>>> This fixes the compile warnings for:
>>>> https://travis-ci.org/u-boot/u-boot/jobs/122880430
>>>>
>>>> see:
>>>> https://travis-ci.org/hsdenx/u-boot/jobs/123238779
>>>>
>>>> arch/arm/dts/skeleton.dtsi | 2 +-
>>>> arch/arm/dts/socfpga.dtsi | 40
>>>> +++++++++++++-------------
>>>> arch/arm/dts/socfpga_arria5_socdk.dts | 2 +-
>>>> arch/arm/dts/socfpga_cyclone5_de0_nano_soc.dts | 2 +-
>>>> arch/arm/dts/socfpga_cyclone5_mcvevk.dts | 2 +-
>>>> arch/arm/dts/socfpga_cyclone5_socdk.dts | 2 +-
>>>> arch/arm/dts/socfpga_cyclone5_sockit.dts | 2 +-
>>>> arch/arm/dts/socfpga_cyclone5_socrates.dts | 2 +-
>>>> 8 files changed, 27 insertions(+), 27 deletions(-)
>>>>
>>>> diff --git a/arch/arm/dts/skeleton.dtsi b/arch/arm/dts/skeleton.dtsi
>>>> index b41d241..a20da0a 100644
>>>> --- a/arch/arm/dts/skeleton.dtsi
>>>> +++ b/arch/arm/dts/skeleton.dtsi
>>>> @@ -9,5 +9,5 @@
>>>> #size-cells = <1>;
>>>> chosen { };
>>>> aliases { };
>>>> - memory { device_type = "memory"; reg = <0 0>; };
>>>> + memory at 0 { device_type = "memory"; reg = <0 0>; };
>>>> };
>>>
>>> Can you split this into skeleton.dtsi patch and socfpga-only patch?
>>> That'd help containing the changes.
>>
>> Yes, of course!
>
> Please hold the patch for a bit, see above.
>

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany