public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] env_ext4: fix build error.
Date: Mon, 18 Apr 2016 13:53:04 +0200	[thread overview]
Message-ID: <5714CAA0.9000604@suse.de> (raw)
In-Reply-To: <1460966116-14027-1-git-send-email-ysato@users.sourceforge.jp>

Am 18.04.2016 um 09:55 schrieb Yoshinori Sato:
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
>  common/env_ext4.c | 20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
> 
> diff --git a/common/env_ext4.c b/common/env_ext4.c
> index ce748ed..5683890 100644
> --- a/common/env_ext4.c
> +++ b/common/env_ext4.c
> @@ -25,6 +25,7 @@
>  #include <environment.h>
>  #include <linux/stddef.h>
>  #include <malloc.h>
> +#include <memalign.h>
>  #include <search.h>
>  #include <errno.h>
>  #include <ext4fs.h>
> @@ -49,7 +50,7 @@ int env_init(void)
>  int saveenv(void)
>  {
>  	env_t	env_new;
> -	block_dev_desc_t *dev_desc = NULL;
> +	struct blk_desc *dev_desc = NULL;
>  	disk_partition_t info;
>  	int dev, part;
>  	int err;
> @@ -58,13 +59,13 @@ int saveenv(void)
>  	if (err)
>  		return err;
>  
> -	part = get_device_and_partition(EXT4_ENV_INTERFACE,
> +	part = blk_get_device_part_str(EXT4_ENV_INTERFACE,
>  					EXT4_ENV_DEVICE_AND_PART,
>  					&dev_desc, &info, 1);

Below you adjusted the indentation, here you didn't?

While at it, you could drop the trailing full stop from the subject.

Regards,
Andreas

>  	if (part < 0)
>  		return 1;
>  
> -	dev = dev_desc->dev;
> +	dev = dev_desc->devnum;
>  	ext4fs_set_blk_dev(dev_desc, &info);
>  
>  	if (!ext4fs_mount(info.size)) {
> @@ -90,18 +91,19 @@ int saveenv(void)
>  void env_relocate_spec(void)
>  {
>  	ALLOC_CACHE_ALIGN_BUFFER(char, buf, CONFIG_ENV_SIZE);
> -	block_dev_desc_t *dev_desc = NULL;
> +	struct blk_desc *dev_desc = NULL;
>  	disk_partition_t info;
>  	int dev, part;
>  	int err;
> +	long long int actread;
>  
> -	part = get_device_and_partition(EXT4_ENV_INTERFACE,
> -					EXT4_ENV_DEVICE_AND_PART,
> -					&dev_desc, &info, 1);
> +	part = blk_get_device_part_str(EXT4_ENV_INTERFACE,
> +				       EXT4_ENV_DEVICE_AND_PART,
> +				       &dev_desc, &info, 1);
>  	if (part < 0)
>  		goto err_env_relocate;
>  
> -	dev = dev_desc->dev;
> +	dev = dev_desc->devnum;
>  	ext4fs_set_blk_dev(dev_desc, &info);
>  
>  	if (!ext4fs_mount(info.size)) {
> @@ -110,7 +112,7 @@ void env_relocate_spec(void)
>  		goto err_env_relocate;
>  	}
>  
> -	err = ext4_read_file(EXT4_ENV_FILE, buf, 0, CONFIG_ENV_SIZE);
> +	err = ext4_read_file(EXT4_ENV_FILE, buf, 0, CONFIG_ENV_SIZE, &actread);
>  	ext4fs_close();
>  
>  	if (err == -1) {

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)

      reply	other threads:[~2016-04-18 11:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-18  7:55 [U-Boot] [PATCH] env_ext4: fix build error Yoshinori Sato
2016-04-18 11:53 ` Andreas Färber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5714CAA0.9000604@suse.de \
    --to=afaerber@suse.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox