[U-Boot] [PATCH] arm: dts: socfpga: fix DTC unit name warnings

Heiko Schocher
2016-04-18T11:06:35Z

Hello Pavel,

Am 18.04.2016 um 12:00 schrieb Pavel Machek:
> Hi!
>
>>> Hi!
>>>
>>>> Warning (unit_address_vs_reg): Node /soc/usbphy at 0 has a unit name,
>>>> but no reg property
>>>
>>> I don't know who produces the warnings, but perhaps fix the tool,
>>> instead?
>>
>> This warnigns poping up with new DTC compilers, introduced from dtc
>> commit:
>
> IMO compiler should be fixed.

A simple revert of this commit fixes it ... yes, but, see below.

>> ePAPR 1.1 section 2.2.1.1 "Node Name Requirements" specifies
>> that any
>
> This is arm. This is not powerpc. It is 2016, not 1997.

Hmm...

>>>> - usbphy0: usbphy at 0 {
>>>> + usbphy0: usbphy {
>>>> #phy-cells = <0>;
>>>> compatible = "usb-nop-xceiv";
>>>> status = "okay";
>>>
>>> And this sounds like a bug waiting to happen..
>>
>> Better fix would be to add the reg property .. could you help me?
>
> Introduce fake "reg" property to shut up warning?

or fix "usbphy at 0" to "usbphy0".

> I guess this should be solved on the kernel list, and I believe the
> warnings are wrong.

I think it is discussed on the kernel mailinglist, see for example:

http://permalink.gmane.org/gmane.comp.devicetree.compiler/432

Nice here the comment from rob:
"Any objections to this series will result in getting added as a DT
binding maintainer. :)"

So, feel free to speak up!

bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany