From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: mx5: Fix NAND image generation
Date: Tue, 19 Apr 2016 15:55:37 +0200 [thread overview]
Message-ID: <571638D9.3090705@denx.de> (raw)
In-Reply-To: <1459846446-5893-1-git-send-email-marex@denx.de>
On 05/04/2016 10:54, Marek Vasut wrote:
> The echo -ne "\xNN" does not work in certain bourne-compatible shells, like
> dash. The recommended way of hex->char conversion is using printf(1), but
> there is a pitfall here. The GNU printf does support "\xNN" format, but
> according to the opengroup documentation, this is not part of POSIX. The
> POSIX printf only defines "\NNN" where N is octal. Thus, for the sake of
> compatibility, we use that.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
> arch/arm/imx-common/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/imx-common/Makefile b/arch/arm/imx-common/Makefile
> index 30e66ba..c208628 100644
> --- a/arch/arm/imx-common/Makefile
> +++ b/arch/arm/imx-common/Makefile
> @@ -86,7 +86,7 @@ u-boot-with-nand-spl.imx: spl/u-boot-nand-spl.imx u-boot.uim FORCE
> $(call if_changed,pad_cat)
>
> quiet_cmd_u-boot-nand-spl_imx = GEN $@
> -cmd_u-boot-nand-spl_imx = (echo -ne '\x00\x00\x00\x00\x46\x43\x42\x20\x01' && \
> +cmd_u-boot-nand-spl_imx = (printf '\000\000\000\000\106\103\102\040\001' && \
> dd bs=1015 count=1 if=/dev/zero 2>/dev/null) | cat - $< > $@
>
> spl/u-boot-nand-spl.imx: SPL FORCE
>
Applied to master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
prev parent reply other threads:[~2016-04-19 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 8:54 [U-Boot] [PATCH] arm: mx5: Fix NAND image generation Marek Vasut
2016-04-19 11:49 ` Marek Vasut
2016-04-19 13:55 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571638D9.3090705@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox