From: York Sun <york.sun@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Revert "T2080QDS/PCIe: Soft Reset PCIe on T2080QDS for down-training issue"
Date: Wed, 20 Apr 2016 18:12:24 -0700 [thread overview]
Message-ID: <571828F8.3000202@nxp.com> (raw)
In-Reply-To: <AM3PR04MB11851AE3E9B0B1D411183E20916E0@AM3PR04MB1185.eurprd04.prod.outlook.com>
+Roy to comment on iNIC.
On 04/20/2016 06:05 PM, Qiang Zhao wrote:
> On 04/21/2016 12:58 AM, York Sun wrote:
>> -----Original Message-----
>> From: York Sun [mailto:york.sun at nxp.com]
>> Sent: Thursday, April 21, 2016 12:58 AM
>> To: Qiang Zhao <qiang.zhao@nxp.com>
>> Cc: Xiaobo Xie <xiaobo.xie@nxp.com>; u-boot at lists.denx.de
>> Subject: Re: [PATCH] Revert "T2080QDS/PCIe: Soft Reset PCIe on T2080QDS for
>> down-training issue"
>>
>> On 04/11/2016 02:02 AM, Zhao Qiang wrote:
>>> This reverts commit 5066e62847bddf6030262ade2aa3e7bcdc930037.
>>>
>>> The reverted patch will block t2080RDB iNiC, it was a workaround for
>>> T2080QDS down-training issue, we need to revert it and find the root
>>> cause for T2080QDS down-training issue.
>>
>> You have a bad wrap-back in commit message.
>>
>> Does the workaround block anything? Can you revert it after figuring out the
>> root cause?
>>
>
> Yes, it blocks t2080RDB and c29x when using them as iNIC.
> If revert it after figuring out the root cause, how about iNIC?
> And I am afraid of it is a hard way to find the root cause.
>
Qiang,
You delete the code gated by CONFIG_FSL_PCIE_RESET, and the macro for T208xQDS.
How does that affect T2080RDB or C29x?
York
next prev parent reply other threads:[~2016-04-21 1:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 8:53 [U-Boot] [PATCH] Revert "T2080QDS/PCIe: Soft Reset PCIe on T2080QDS for down-training issue" Zhao Qiang
2016-04-20 16:57 ` York Sun
2016-04-21 1:05 ` Qiang Zhao
2016-04-21 1:12 ` York Sun [this message]
2016-07-19 22:04 ` york sun
2016-07-20 1:27 ` Qiang Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571828F8.3000202@nxp.com \
--to=york.sun@nxp.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox