From mboxrd@z Thu Jan 1 00:00:00 1970 From: York Sun Date: Wed, 20 Apr 2016 18:12:24 -0700 Subject: [U-Boot] [PATCH] Revert "T2080QDS/PCIe: Soft Reset PCIe on T2080QDS for down-training issue" In-Reply-To: References: <1460364798-44182-1-git-send-email-qiang.zhao@nxp.com> <5717B4FD.9060301@nxp.com> Message-ID: <571828F8.3000202@nxp.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de +Roy to comment on iNIC. On 04/20/2016 06:05 PM, Qiang Zhao wrote: > On 04/21/2016 12:58 AM, York Sun wrote: >> -----Original Message----- >> From: York Sun [mailto:york.sun at nxp.com] >> Sent: Thursday, April 21, 2016 12:58 AM >> To: Qiang Zhao >> Cc: Xiaobo Xie ; u-boot at lists.denx.de >> Subject: Re: [PATCH] Revert "T2080QDS/PCIe: Soft Reset PCIe on T2080QDS for >> down-training issue" >> >> On 04/11/2016 02:02 AM, Zhao Qiang wrote: >>> This reverts commit 5066e62847bddf6030262ade2aa3e7bcdc930037. >>> >>> The reverted patch will block t2080RDB iNiC, it was a workaround for >>> T2080QDS down-training issue, we need to revert it and find the root >>> cause for T2080QDS down-training issue. >> >> You have a bad wrap-back in commit message. >> >> Does the workaround block anything? Can you revert it after figuring out the >> root cause? >> > > Yes, it blocks t2080RDB and c29x when using them as iNIC. > If revert it after figuring out the root cause, how about iNIC? > And I am afraid of it is a hard way to find the root cause. > Qiang, You delete the code gated by CONFIG_FSL_PCIE_RESET, and the macro for T208xQDS. How does that affect T2080RDB or C29x? York