From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mateusz Kulikowski Date: Fri, 22 Apr 2016 16:12:15 +0200 Subject: [U-Boot] [PATCH 2/3] drivers/gpio/pm8916_gpio.c: Make pid be uint32_t In-Reply-To: <20160420212541.GB3732@bill-the-cat> References: <1460488284-26713-1-git-send-email-trini@konsulko.com> <1460488284-26713-2-git-send-email-trini@konsulko.com> <5715423C.9060700@gmail.com> <20160420212541.GB3732@bill-the-cat> Message-ID: <571A313F.40303@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi, On 20.04.2016 23:25, Tom Rini wrote: > On Mon, Apr 18, 2016 at 10:23:24PM +0200, Mateusz Kulikowski wrote: [..] >> >> I think (now, when the coverity pointed out mistake) that we should add >> in that case check if pid fits in 16-bits, as this is maximum pid value on spmi bus. >> >> This checks should be done in pm8916_gpio_probe() and pm8916_probe(). >> >> Would you like to do it in your series or want me to post another patch on top of them? > > Please do a follow up, thanks! > Will do that, but it will take a few days as I have a lot of non-coding related assignments now :) btw. SPMI core checks pid and sid internally during reads/writes so we're pretty safe anyway. Regards, Mateusz -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXGjE2AAoJELvtohmVtQzBMj4H/3+zypiWH9BZdDheztNA6yZt vN2fIz9kWQB8GFoBktU7kRAAWXaTDB0CWsKQmcqnJtZJeqyUV0Dj1CEJoS4fcptD Lq0uljuufLkfkSb/XhRe5sLxWbvygHVrGBz/OemFCQivBlu8MEe4pwNyEUFwTHrc otF9Uk1y92HjsyaQhjMX6WWR5Ei8hrVSryppt1eRFoGBAw9uL7TcKnc96IKrbFZ+ ns/40n/K8O2k8J2JMxMXB1QbJj/lEj/y4yY2Il2B2Z3WHb4ZhErtoko55uh0bGf4 PoGH1wPTZxNrcKn0CCwnHxmIxGJMpJ8XyZYhsEI4J+ZBs7izzb4dSn8ekOsr1nI= =Y2ca -----END PGP SIGNATURE-----