From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Fri, 22 Apr 2016 14:42:40 -0600 Subject: [U-Boot] [PATCH 30/60] ARM: tegra: remove pmu.h In-Reply-To: References: <1461099580-3866-1-git-send-email-swarren@wwwdotorg.org> <1461099580-3866-31-git-send-email-swarren@wwwdotorg.org> Message-ID: <571A8CC0.2010803@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/22/2016 12:32 PM, Simon Glass wrote: > Hi Stephen, > > On 19 April 2016 at 14:59, Stephen Warren wrote: >> From: Stephen Warren >> >> This header is duplicated many times, and does nothing but prototype a >> single function that's used solely by mach-tegra code. Move the proto- >> type of mach-tegra/cpu.h. That's not an awesome location for it, but >> other similar functions like pmic_enable_cpu_vdd() are already there. > Reviewed-by: Simon Glass > > I wonder if it would be better to retain the header name and move > pmic_enable_cpu_vdd()? I think that pmu_set_nominal() (the function moved into cpu.h by this patch) and pmic_enable_cpu_vdd() serve essentially the same semantic purpose, but are used on different sets of SoCs via ifdefs or weak functions. I expect that early in the part 2 series, I'll get rid of more code in board2.c's board_init() and put it into something like tegra_board_init_soc(), prototyped in board_init.h or soc_init.h. Or put another way, I expect I'll clean up the "not a great location" issue mentioned in this patch description pretty soon.