public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] distro: Disable iso partition format for SPL
Date: Mon, 25 Apr 2016 17:18:38 +0200	[thread overview]
Message-ID: <571E354E.1040908@denx.de> (raw)
In-Reply-To: <571E3215.5050404@suse.de>

Hello Alexander,

Am 25.04.2016 um 17:04 schrieb Alexander Graf:
> On 04/25/2016 05:03 PM, Heiko Schocher wrote:
>> Hello Alexander,
>>
>> Am 25.04.2016 um 14:55 schrieb Alexander Graf:
>>> When building an SPL binary, chances are quite slim that we need an
>>> iso partition label. However, there were reports of us exceeding our
>>> SPL memory limit with iso enabled.
>>>
>>> So for now, let's disable the ISO partition format code when in the
>>> SPL build.
>>>
>>> Reported-by: Heiko Schocher <hs@denx.de>
>>> Signed-off-by: Alexander Graf <agraf@suse.de>
>>> ---
>>>   include/config_distro_defaults.h | 5 ++++-
>>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> Thanks for the fix!
>>
>> Acked-by: Heiko Schocher <hs@denx.de>
>
> Did you test and verify that this fixes the issue for you? My local compile was still too big, but I
> guess that's a toolchain difference thing :)

I tested this patch for an am335x port, I soon post to mainline. With
this patch, it compiled again clean for me.

Just tried the "igep0030_nand_defconfig" ... yes, it fails also with
this patch:

without your patch:
arm-linux-gnueabi-ld.bfd: region `.sram' overflowed by 1176 bytes

with it:
arm-linux-gnueabi-ld.bfd: region `.sram' overflowed by 272 bytes

So, your patch saves some bytes, but this fix seems valid for me, so I
acked it ... But it seems, there are more issues with this board ...

Ah, Tom already posted another fix, see:
http://patchwork.ozlabs.org/patch/614516/

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2016-04-25 15:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25 12:55 [U-Boot] [PATCH] distro: Disable iso partition format for SPL Alexander Graf
2016-04-25 15:03 ` Heiko Schocher
2016-04-25 15:04   ` Alexander Graf
2016-04-25 15:18     ` Heiko Schocher [this message]
2016-04-25 15:21       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571E354E.1040908@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox