From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Mon, 25 Apr 2016 17:18:38 +0200 Subject: [U-Boot] [PATCH] distro: Disable iso partition format for SPL In-Reply-To: <571E3215.5050404@suse.de> References: <1461588930-103058-1-git-send-email-agraf@suse.de> <571E31DE.9050001@denx.de> <571E3215.5050404@suse.de> Message-ID: <571E354E.1040908@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Alexander, Am 25.04.2016 um 17:04 schrieb Alexander Graf: > On 04/25/2016 05:03 PM, Heiko Schocher wrote: >> Hello Alexander, >> >> Am 25.04.2016 um 14:55 schrieb Alexander Graf: >>> When building an SPL binary, chances are quite slim that we need an >>> iso partition label. However, there were reports of us exceeding our >>> SPL memory limit with iso enabled. >>> >>> So for now, let's disable the ISO partition format code when in the >>> SPL build. >>> >>> Reported-by: Heiko Schocher >>> Signed-off-by: Alexander Graf >>> --- >>> include/config_distro_defaults.h | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> Thanks for the fix! >> >> Acked-by: Heiko Schocher > > Did you test and verify that this fixes the issue for you? My local compile was still too big, but I > guess that's a toolchain difference thing :) I tested this patch for an am335x port, I soon post to mainline. With this patch, it compiled again clean for me. Just tried the "igep0030_nand_defconfig" ... yes, it fails also with this patch: without your patch: arm-linux-gnueabi-ld.bfd: region `.sram' overflowed by 1176 bytes with it: arm-linux-gnueabi-ld.bfd: region `.sram' overflowed by 272 bytes So, your patch saves some bytes, but this fix seems valid for me, so I acked it ... But it seems, there are more issues with this board ... Ah, Tom already posted another fix, see: http://patchwork.ozlabs.org/patch/614516/ bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany