From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 13/60] ARM: tegra: sort some board file include directives
Date: Mon, 25 Apr 2016 13:54:10 -0600 [thread overview]
Message-ID: <571E75E2.6020008@wwwdotorg.org> (raw)
In-Reply-To: <20160424102050.AD0C110028B@atlas.denx.de>
On 04/24/2016 04:20 AM, Wolfgang Denk wrote:
> Dear Stephen,
>
> In message <1461099580-3866-14-git-send-email-swarren@wwwdotorg.org> you wrote:
>>
>> --- a/board/avionic-design/common/tamonten-ng.c
>> +++ b/board/avionic-design/common/tamonten-ng.c
>> @@ -1,18 +1,19 @@
>> /*
>> * (C) Copyright 2013
>> * Avionic Design GmbH <www.avionic-design.de>
>> + * Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved.
>> *
>> * SPDX-License-Identifier: GPL-2.0+
>> */
>>
>> #include <common.h>
>> #include <dm.h>
>> +#include <i2c.h>
>> +#include <asm/gpio.h>
>> #include <asm/arch/pinmux.h>
>> #include <asm/arch/gp_padctrl.h>
>> #include <asm/arch/gpio.h>
>> -#include <asm/gpio.h>
>> #include "pinmux-config-tamonten-ng.h"
>> -#include <i2c.h>
>>
>> #define PMU_I2C_ADDRESS 0x2D
>
> Do you really think that moving around two lines of code is a big
> enough creative achievement to justify adding a copyright note on it?
My understanding is yes; I edited the file in a non-trival way and so
NVIDIA's copyright applies to those portions. I'd consider whitespace or
spelling fixes to be trivial, but not much else. I believe there is
creative achievement in cleaning up the code-base this way.
Of course, I'm not a lawyer and I'm sure there are plenty of lawyers who
could argue either way, perhaps depending on who pays them:-)
> I'm sorry, but I really dislike
> the way how it - intentionally or unintentionally - appears to be
> driven by the attempt to increase Nvidias presence in copyright
> claims.
FWIW, the purpose is to create a cleaner separate between the core Tegra
SoC support code and board/driver code, to reduce their current rather
tight coupling. The copyright changes are just correct application of
the process of editing files; something I admit we/I've been a bit lax
about in the past.
> This seems not fair to me, and I would like to ask you to rework this
> whole patch set and be a little less aggressive in copyright claims.
I don't see what's unfair either way. As far as I'm concerned, the
copyright notices are simply due to my following the process I must
follow. I don't believe the presence of NVIDIA's copyright notices takes
anything away from anyone else, and as I mentioned above, they seem
valid to me.
next prev parent reply other threads:[~2016-04-25 19:54 UTC|newest]
Thread overview: 177+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 20:58 [U-Boot] [PATCH 00/60] ARM: tegra: cleanup part 1 Stephen Warren
2016-04-19 20:58 ` [U-Boot] [PATCH 01/60] ARM: tegra: remove unused definitions in headers Stephen Warren
2016-04-20 19:25 ` Simon Glass
2016-04-24 10:20 ` Wolfgang Denk
2016-04-25 19:34 ` Stephen Warren
2016-04-25 21:46 ` Wolfgang Denk
2016-04-25 22:00 ` Stephen Warren
2016-04-25 21:54 ` Simon Glass
2016-04-25 22:02 ` Stephen Warren
2016-04-25 22:15 ` Simon Glass
2016-04-25 22:16 ` Tom Rini
2016-04-19 20:58 ` [U-Boot] [PATCH 02/60] mmc: tegra: move pad init into MMC driver Stephen Warren
2016-04-20 19:25 ` Simon Glass
2016-04-24 10:20 ` Wolfgang Denk
2016-04-25 19:42 ` Stephen Warren
2016-04-25 21:52 ` Wolfgang Denk
2016-04-25 22:37 ` Tom Rini
2016-04-25 22:43 ` Stephen Warren
2016-04-25 23:05 ` Tom Rini
2016-04-25 23:11 ` Stephen Warren
2016-04-25 23:26 ` Tom Rini
2016-04-25 23:34 ` Stephen Warren
2016-04-26 0:14 ` Tom Rini
2016-04-26 16:21 ` Stephen Warren
2016-04-26 18:15 ` Tom Rini
2016-04-26 18:09 ` Wolfgang Denk
2016-04-19 20:58 ` [U-Boot] [PATCH 03/60] mmc: tegra: move header file to driver directory Stephen Warren
2016-04-20 19:25 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 04/60] mmc: tegra: move public header to arch/arm/mach-tegra/include Stephen Warren
2016-04-20 19:25 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 05/60] pwm: tegra: move header file to driver directory Stephen Warren
2016-04-20 19:25 ` Simon Glass
2016-04-24 10:20 ` Wolfgang Denk
2016-04-25 19:47 ` Stephen Warren
2016-04-19 20:58 ` [U-Boot] [PATCH 06/60] i2c: " Stephen Warren
2016-04-20 4:48 ` Heiko Schocher
2016-04-20 19:25 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 07/60] usb: " Stephen Warren
2016-04-20 19:25 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 08/60] video: " Stephen Warren
2016-04-20 19:26 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 09/60] ARM: tegra: correct 64-bit DT unit addresses Stephen Warren
2016-04-20 19:26 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 10/60] ARM: tegra: sort DT /aliases entries Stephen Warren
2016-04-20 19:26 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 11/60] ARM: tegra: add DT alias for GPIO controller Stephen Warren
2016-04-20 19:26 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 12/60] gpio: tegra: remove duplicate define Stephen Warren
2016-04-20 19:26 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 13/60] ARM: tegra: sort some board file include directives Stephen Warren
2016-04-20 19:26 ` Simon Glass
2016-04-24 10:20 ` Wolfgang Denk
2016-04-25 19:54 ` Stephen Warren [this message]
2016-04-25 21:59 ` Wolfgang Denk
2016-04-25 23:22 ` Tom Rini
2016-04-26 16:18 ` Stephen Warren
2016-04-26 18:13 ` Wolfgang Denk
2016-04-26 18:20 ` Wolfgang Denk
2016-04-26 18:15 ` Tom Rini
2016-04-26 20:44 ` Stephen Warren
2016-04-26 23:29 ` Tom Rini
2016-04-26 16:23 ` Stephen Warren
2016-04-26 18:15 ` Tom Rini
2016-04-19 20:58 ` [U-Boot] [PATCH 14/60] ARM: tegra: use DT bindings for GPIO naming Stephen Warren
2016-04-20 19:26 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 15/60] gpio: tegra: header file split Stephen Warren
2016-04-20 19:26 ` Simon Glass
2016-04-20 22:01 ` Stephen Warren
2016-04-21 14:11 ` Simon Glass
2016-04-21 16:40 ` Stephen Warren
2016-04-21 16:51 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 16/60] ARM: tegra: migrate TEGRA_GPIO to Kconfig Stephen Warren
2016-04-20 19:26 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 17/60] ARM: tegra: move apb_misc.h Stephen Warren
2016-04-20 19:26 ` Simon Glass
2016-04-20 21:56 ` Stephen Warren
2016-04-21 20:59 ` Simon Glass
2016-04-21 21:14 ` Stephen Warren
2016-04-19 20:58 ` [U-Boot] [PATCH 18/60] ARM: tegra: move fuse.h Stephen Warren
2016-04-22 18:30 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 19/60] ARM: tegra: move gpu.h Stephen Warren
2016-04-22 18:30 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 20/60] ARM: tegra: move pmc.h Stephen Warren
2016-04-22 18:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 21/60] ARM: tegra: move scu.h Stephen Warren
2016-04-22 18:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 22/60] ARM: tegra: move warmboot.h Stephen Warren
2016-04-22 18:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 23/60] ARM: tegra: move xusb-padctl.h to <mach/> Stephen Warren
2016-04-22 18:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 24/60] ARM: tegra: unify+move {board, sys_proto}.h " Stephen Warren
2016-04-22 18:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 25/60] ARM: tegra: use consistently named include guards Stephen Warren
2016-04-22 18:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 26/60] ARM: tegra: delete unused headers Stephen Warren
2016-04-22 18:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 27/60] ARM: tegra: move emc.h Stephen Warren
2016-04-22 18:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 28/60] ARM: tegra: move sdram_param.h Stephen Warren
2016-04-22 18:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 29/60] ARM: tegra: move sysctr.h Stephen Warren
2016-04-22 18:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 30/60] ARM: tegra: remove pmu.h Stephen Warren
2016-04-22 18:32 ` Simon Glass
2016-04-22 20:42 ` Stephen Warren
2016-04-19 20:59 ` [U-Boot] [PATCH 31/60] ARM: tegra: move powergate.h to <mach/> Stephen Warren
2016-04-22 18:33 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 32/60] ARM: tegra: add SoC-specific include directory Stephen Warren
2016-04-22 18:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 33/60] ARM: tegra: fix bug in Tegra20 flow.h Stephen Warren
2016-04-22 18:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 34/60] ARM: tegra: move flow.h Stephen Warren
2016-04-22 18:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 35/60] nyan-big: remove direct MC register access Stephen Warren
2016-04-22 18:33 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 36/60] ARM: tegra: move mc.h Stephen Warren
2016-04-22 18:33 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 37/60] ARM: tegra: move SDIOCFG_DRV* to pinmux.h Stephen Warren
2016-04-23 17:14 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 38/60] ARM: tegra: remove tegra_get_chip() Stephen Warren
2016-04-23 17:14 ` Simon Glass
2016-04-25 19:25 ` Stephen Warren
2016-04-27 14:50 ` Simon Glass
2016-04-27 16:13 ` Stephen Warren
2016-04-29 14:02 ` Simon Glass
2016-04-29 16:27 ` Stephen Warren
2016-04-29 16:53 ` Simon Glass
2016-04-29 17:42 ` Simon Glass
2016-04-29 19:21 ` Stephen Warren
2016-05-01 19:16 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 39/60] ARM: tegra: remove get_num_cpus() Stephen Warren
2016-04-19 20:59 ` [U-Boot] [PATCH 40/60] ARM: tegra: remove gp_padctrl.h Stephen Warren
2016-05-07 22:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 41/60] ARM: tegra: remove tegra_get_sku_info() Stephen Warren
2016-05-07 22:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 42/60] ARM: tegra: move EMC code to tegra20/ directory Stephen Warren
2016-05-07 22:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 43/60] ARM: tegra: move PLLX configuration into SoC directories Stephen Warren
2016-05-07 22:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 44/60] ARM: tegra: remove tegra_get_chip_sku() Stephen Warren
2016-05-07 22:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 45/60] ARM: tegra: move custom pinmux.h to <mach/> Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 46/60] ARM: tegra: add pinmux APIs to replace funcmux Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 47/60] ARM: tegra: provide API for SPL code to init UART Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 48/60] ARM: tegra: lay groundwork for board hook cleanup Stephen Warren
2016-04-19 20:59 ` [U-Boot] [PATCH 49/60] ARM: tegra: convert boards to new hooks Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 50/60] ARM: tegra: remove unused includes Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 51/60] ARM: tegra: move SPL-specific GPIO device to spl.c Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 52/60] ARM: tegra: convert pin_mux_*() to new hooks Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 53/60] tegra: keyboard: move pinmux setup to board files Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 54/60] video: tegra: " Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 55/60] i2c: " Stephen Warren
2016-04-27 15:12 ` Simon Glass
2016-04-27 16:24 ` Stephen Warren
2016-04-27 16:58 ` Simon Glass
2016-04-27 17:16 ` Stephen Warren
2016-04-29 14:02 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 56/60] ARM: tegra: remove funcmux API Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 57/60] ARM: tegra: don't access Boot Info Table from board code Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 58/60] ARM: tegra: clean up board include statements Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 59/60] ARM: tegra: unify+move tegra.h to mach-tegra/ Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 60/60] ARM: tegra: move clock headers Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-05-07 22:32 ` [U-Boot] [PATCH 00/60] ARM: tegra: cleanup part 1 Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571E75E2.6020008@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox