From: Florian Fainelli <f.fainelli@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] phy: Add phy driver support for xilinx PCS/PMA core
Date: Mon, 25 Apr 2016 15:40:38 -0700 [thread overview]
Message-ID: <571E9CE6.7030905@gmail.com> (raw)
In-Reply-To: <CANr=Z=bFdPKJuV3oSi9TDmRvNOHreXsfUAUfAg=FctDAMqFjAw@mail.gmail.com>
On 25/04/16 15:36, Joe Hershberger wrote:
> On Mon, Feb 15, 2016 at 3:54 AM, Michal Simek <michal.simek@xilinx.com> wrote:
>> From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
>>
>> Add phy driver support for xilinx PCS/PMA core
>>
>> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
>> Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
[snip]
>> +static int xilinxphy_of_init(struct phy_device *phydev)
>> +{
>> + struct udevice *dev = (struct udevice *)&phydev->dev;
>> + u32 phytype;
>> +
>> + debug("%s\n", __func__);
>> + phytype = fdtdec_get_int(gd->fdt_blob, dev->of_offset, "phy-type", -1);
>
> Is there a bindings document that can be included to describe this?
If that is meant to be the PHY type (MII, RGMII etc.) the standard
property name is either 'phy-mode' or 'phy-connection-type', the latter
being the one described in ePAPR, while the former has been widely
adopted by Linux nowadays (and other OSes possibly).
My 2 cents since I don't typically review u-boot changes.
--
Florian
next prev parent reply other threads:[~2016-04-25 22:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 9:54 [U-Boot] [PATCH 1/3] phy: Add phy driver support for xilinx PCS/PMA core Michal Simek
2016-02-15 9:55 ` [U-Boot] [PATCH 2/3] net: zynq_gem: Add support for SGMII interface Michal Simek
2016-04-25 22:33 ` Joe Hershberger
2016-02-15 9:55 ` [U-Boot] [PATCH 3/3] zynq-common: Enable phy driver for Xilinx PCS/PMA core Michal Simek
2016-04-25 22:36 ` [U-Boot] [PATCH 1/3] phy: Add phy driver support for xilinx " Joe Hershberger
2016-04-25 22:40 ` Florian Fainelli [this message]
2016-04-26 6:13 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571E9CE6.7030905@gmail.com \
--to=f.fainelli@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox