From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Date: Mon, 25 Apr 2016 15:40:38 -0700 Subject: [U-Boot] [PATCH 1/3] phy: Add phy driver support for xilinx PCS/PMA core In-Reply-To: References: Message-ID: <571E9CE6.7030905@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 25/04/16 15:36, Joe Hershberger wrote: > On Mon, Feb 15, 2016 at 3:54 AM, Michal Simek wrote: >> From: Siva Durga Prasad Paladugu >> >> Add phy driver support for xilinx PCS/PMA core >> >> Signed-off-by: Siva Durga Prasad Paladugu >> Signed-off-by: Kedareswara rao Appana >> Signed-off-by: Michal Simek >> --- [snip] >> +static int xilinxphy_of_init(struct phy_device *phydev) >> +{ >> + struct udevice *dev = (struct udevice *)&phydev->dev; >> + u32 phytype; >> + >> + debug("%s\n", __func__); >> + phytype = fdtdec_get_int(gd->fdt_blob, dev->of_offset, "phy-type", -1); > > Is there a bindings document that can be included to describe this? If that is meant to be the PHY type (MII, RGMII etc.) the standard property name is either 'phy-mode' or 'phy-connection-type', the latter being the one described in ePAPR, while the former has been widely adopted by Linux nowadays (and other OSes possibly). My 2 cents since I don't typically review u-boot changes. -- Florian