[U-Boot] [PATCH 53/60] tegra: keyboard: move pinmux setup to board files

Simon Glass
2016-05-07T22:32:22Z

Hi Stephen.

On 19 April 2016 at 14:59, Stephen Warren <swarren@wwwdotorg.org> wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Remove funcmux calls from the Tegra keyboard driver. Knowledge of pinmux
> setup must come from either board files or DT; it should not be embedded
> into board-agnostic driver code. The DT pinmux bindings do not allow
> drivers to derive funcmux-style information, since the DT bindings are
> pin-based whereas funcmux is controller-based, so there's no good way to
> call the existing funcmux APIs from drivers. Converting drivers to use a
> new (as yet non-existent in U-Boot) API that pulls pinmux information from
> DT isn't useful for Tegra, since Tegra's DT files don't contain any
> per-device pinmux tables, so this would simply be extra code that has no
> effect; doesn't actually set up the pinmux. We are left with moving the
> pinmux setup functionality into board files. In theory the board files
> could be converted later to use DT, but that would be a separate change.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> board/nvidia/seaboard/seaboard.c | 1 +
> drivers/input/tegra-kbc.c | 3 ---
> 2 files changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

With a pinctrl driver this can happen automatically, or you can load
your single table in the probe() method.

Regards,
Simon