[U-Boot] [PATCH 05/60] pwm: tegra: move header file to driver directory

Wolfgang Denk
2016-04-24T10:20:48Z

Dear Stephen,

In message <1461099580-3866-6-git-send-email-swarren@wwwdotorg.org> you wrote:
>
> Tegra's pwm.h only contains private definitions for use inside the Tegra
> PWM driver. Move it out of the global include directory since nothing
> needs to access it there.

If I understand correctly, all this is just a reorganisation of code.
There is no new code or functionality added, right?

> -/*
> - * Tegra pulse width frequency modulator definitions
> - *
> - * Copyright (c) 2011 The Chromium OS Authors.
...

> -/*
> - * Tegra pulse width frequency modulator definitions
> - *
> - * Copyright (c) 2011 The Chromium OS Authors.
...

> /*
> * Copyright 2016 Google Inc.
> + * Copyright (c) 2014-2016, NVIDIA CORPORATION. All rights reserved.
...

But then, you drop the original copyright notices of the Chromium
project, and replace it by a Nvidia note, and even with this
exasperating "All rights reserved" note.

Sorry, but this seems politically incorrect to me.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The connection between the language in which we think/program and the
problems and solutions we can imagine is very close. For this reason
restricting language features with the intent of eliminating pro-
grammer errors is at best dangerous.
- Bjarne Stroustrup in "The C++ Programming Language"