From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 13/60] ARM: tegra: sort some board file include directives
Date: Tue, 26 Apr 2016 14:44:24 -0600 [thread overview]
Message-ID: <571FD328.50301@wwwdotorg.org> (raw)
In-Reply-To: <20160426181536.GW29322@bill-the-cat>
On 04/26/2016 12:15 PM, Tom Rini wrote:
> On Tue, Apr 26, 2016 at 10:18:06AM -0600, Stephen Warren wrote:
>> On 04/25/2016 05:22 PM, Tom Rini wrote:
>> ...
>>> I know company lawyers come up with various policies and some are more
>>> restrictive than others. Anything about the exact guidelines you can
>>> share would be appreciated.
>>
>> They're simple and I would assume quite standard:
>>
>> 1) When creating a new file, add an NVIDIA copyright header.
>>
>> 2) When performing a non-trival edit to an existing file, if it has
>> an existing NVIDIA copyright header, update the data, and if not,
>> add one.
>>
>> Guidance on "non-trivial" isn't given. I would take it to mean
>> anything other than typos and whitespace fixes.
>>
>> Re-ordering your email slightly:
>>> I want to echo my agreement on this point. Re-ordering includes does
>>> not rise to the level of adding copyright/author/etc lines.
>>
>> I can see your argument re: copyright headers in the individual
>> files, although again I'd echo my previous comments re: a simple and
>> unambiguous process being preferable.
>
> Here's where I hope I don't get everyone at NVIDIA that's doing Linux
> Kernel or other F/OSS work in trouble. Point #1 above is quite
> understandable. Point #2 is something I can see but has totally not
> been done by the folks doing Linux Kernel work.
Admittedly compliance is spotty; the last thing someone wants to do when
having completed a patch is think about all kinds of nit-picks like
updating copyrights, checkpatch, testing, even compiling:-)
However, it's certainly not unheard of. Here are a few examples I was
able to spot quickly:
NVIDIA:
af6313d61a78 (Alex Courbot)
08acae34e8da (Paul Walsmley)
891846516317 (Thierry Reding)
783c8f4c8445 (Peter De Schrijver)
0ffdd4b61b13 (Stephen Warren)
Red Hat
1363074667a6 (Hans De Goede)
25462f7f5295 (Wei Huang)
54cea3f6681a (Milan Broz)
Texas Instruments
2f67864b6d5b (Andrew F. Davis)
0d6fa53fd805 (Andy Gross)
Denx
88eeb72ec4c1 (Stefan Roese)
Admittedly those don't look like refactoring changes, but it sounded to
me like you were arguing completely against point (2) in my original
email above. That's not reasonable. Arguing against (2) for simple
refactoring could be.
> The review on this patch series itself has indeed been derailed, which I
> do not like either. With respect to copyright on individual changes and
> so forth, is this a concern you have, or a concern the lawyers at NVIDIA
> have?
The lawyers have dictated the process which I should follow. I often
forget, so I made sure that for such a large series I'd follow the
process correctly this time. To be honest, I'm way beyond care about
anything to do with copyright at this point; I'd rather just work on
something where it wasn't an issue in any form at all.
next prev parent reply other threads:[~2016-04-26 20:44 UTC|newest]
Thread overview: 177+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 20:58 [U-Boot] [PATCH 00/60] ARM: tegra: cleanup part 1 Stephen Warren
2016-04-19 20:58 ` [U-Boot] [PATCH 01/60] ARM: tegra: remove unused definitions in headers Stephen Warren
2016-04-20 19:25 ` Simon Glass
2016-04-24 10:20 ` Wolfgang Denk
2016-04-25 19:34 ` Stephen Warren
2016-04-25 21:46 ` Wolfgang Denk
2016-04-25 22:00 ` Stephen Warren
2016-04-25 21:54 ` Simon Glass
2016-04-25 22:02 ` Stephen Warren
2016-04-25 22:15 ` Simon Glass
2016-04-25 22:16 ` Tom Rini
2016-04-19 20:58 ` [U-Boot] [PATCH 02/60] mmc: tegra: move pad init into MMC driver Stephen Warren
2016-04-20 19:25 ` Simon Glass
2016-04-24 10:20 ` Wolfgang Denk
2016-04-25 19:42 ` Stephen Warren
2016-04-25 21:52 ` Wolfgang Denk
2016-04-25 22:37 ` Tom Rini
2016-04-25 22:43 ` Stephen Warren
2016-04-25 23:05 ` Tom Rini
2016-04-25 23:11 ` Stephen Warren
2016-04-25 23:26 ` Tom Rini
2016-04-25 23:34 ` Stephen Warren
2016-04-26 0:14 ` Tom Rini
2016-04-26 16:21 ` Stephen Warren
2016-04-26 18:15 ` Tom Rini
2016-04-26 18:09 ` Wolfgang Denk
2016-04-19 20:58 ` [U-Boot] [PATCH 03/60] mmc: tegra: move header file to driver directory Stephen Warren
2016-04-20 19:25 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 04/60] mmc: tegra: move public header to arch/arm/mach-tegra/include Stephen Warren
2016-04-20 19:25 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 05/60] pwm: tegra: move header file to driver directory Stephen Warren
2016-04-20 19:25 ` Simon Glass
2016-04-24 10:20 ` Wolfgang Denk
2016-04-25 19:47 ` Stephen Warren
2016-04-19 20:58 ` [U-Boot] [PATCH 06/60] i2c: " Stephen Warren
2016-04-20 4:48 ` Heiko Schocher
2016-04-20 19:25 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 07/60] usb: " Stephen Warren
2016-04-20 19:25 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 08/60] video: " Stephen Warren
2016-04-20 19:26 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 09/60] ARM: tegra: correct 64-bit DT unit addresses Stephen Warren
2016-04-20 19:26 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 10/60] ARM: tegra: sort DT /aliases entries Stephen Warren
2016-04-20 19:26 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 11/60] ARM: tegra: add DT alias for GPIO controller Stephen Warren
2016-04-20 19:26 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 12/60] gpio: tegra: remove duplicate define Stephen Warren
2016-04-20 19:26 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 13/60] ARM: tegra: sort some board file include directives Stephen Warren
2016-04-20 19:26 ` Simon Glass
2016-04-24 10:20 ` Wolfgang Denk
2016-04-25 19:54 ` Stephen Warren
2016-04-25 21:59 ` Wolfgang Denk
2016-04-25 23:22 ` Tom Rini
2016-04-26 16:18 ` Stephen Warren
2016-04-26 18:13 ` Wolfgang Denk
2016-04-26 18:20 ` Wolfgang Denk
2016-04-26 18:15 ` Tom Rini
2016-04-26 20:44 ` Stephen Warren [this message]
2016-04-26 23:29 ` Tom Rini
2016-04-26 16:23 ` Stephen Warren
2016-04-26 18:15 ` Tom Rini
2016-04-19 20:58 ` [U-Boot] [PATCH 14/60] ARM: tegra: use DT bindings for GPIO naming Stephen Warren
2016-04-20 19:26 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 15/60] gpio: tegra: header file split Stephen Warren
2016-04-20 19:26 ` Simon Glass
2016-04-20 22:01 ` Stephen Warren
2016-04-21 14:11 ` Simon Glass
2016-04-21 16:40 ` Stephen Warren
2016-04-21 16:51 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 16/60] ARM: tegra: migrate TEGRA_GPIO to Kconfig Stephen Warren
2016-04-20 19:26 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 17/60] ARM: tegra: move apb_misc.h Stephen Warren
2016-04-20 19:26 ` Simon Glass
2016-04-20 21:56 ` Stephen Warren
2016-04-21 20:59 ` Simon Glass
2016-04-21 21:14 ` Stephen Warren
2016-04-19 20:58 ` [U-Boot] [PATCH 18/60] ARM: tegra: move fuse.h Stephen Warren
2016-04-22 18:30 ` Simon Glass
2016-04-19 20:58 ` [U-Boot] [PATCH 19/60] ARM: tegra: move gpu.h Stephen Warren
2016-04-22 18:30 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 20/60] ARM: tegra: move pmc.h Stephen Warren
2016-04-22 18:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 21/60] ARM: tegra: move scu.h Stephen Warren
2016-04-22 18:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 22/60] ARM: tegra: move warmboot.h Stephen Warren
2016-04-22 18:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 23/60] ARM: tegra: move xusb-padctl.h to <mach/> Stephen Warren
2016-04-22 18:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 24/60] ARM: tegra: unify+move {board, sys_proto}.h " Stephen Warren
2016-04-22 18:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 25/60] ARM: tegra: use consistently named include guards Stephen Warren
2016-04-22 18:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 26/60] ARM: tegra: delete unused headers Stephen Warren
2016-04-22 18:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 27/60] ARM: tegra: move emc.h Stephen Warren
2016-04-22 18:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 28/60] ARM: tegra: move sdram_param.h Stephen Warren
2016-04-22 18:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 29/60] ARM: tegra: move sysctr.h Stephen Warren
2016-04-22 18:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 30/60] ARM: tegra: remove pmu.h Stephen Warren
2016-04-22 18:32 ` Simon Glass
2016-04-22 20:42 ` Stephen Warren
2016-04-19 20:59 ` [U-Boot] [PATCH 31/60] ARM: tegra: move powergate.h to <mach/> Stephen Warren
2016-04-22 18:33 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 32/60] ARM: tegra: add SoC-specific include directory Stephen Warren
2016-04-22 18:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 33/60] ARM: tegra: fix bug in Tegra20 flow.h Stephen Warren
2016-04-22 18:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 34/60] ARM: tegra: move flow.h Stephen Warren
2016-04-22 18:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 35/60] nyan-big: remove direct MC register access Stephen Warren
2016-04-22 18:33 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 36/60] ARM: tegra: move mc.h Stephen Warren
2016-04-22 18:33 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 37/60] ARM: tegra: move SDIOCFG_DRV* to pinmux.h Stephen Warren
2016-04-23 17:14 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 38/60] ARM: tegra: remove tegra_get_chip() Stephen Warren
2016-04-23 17:14 ` Simon Glass
2016-04-25 19:25 ` Stephen Warren
2016-04-27 14:50 ` Simon Glass
2016-04-27 16:13 ` Stephen Warren
2016-04-29 14:02 ` Simon Glass
2016-04-29 16:27 ` Stephen Warren
2016-04-29 16:53 ` Simon Glass
2016-04-29 17:42 ` Simon Glass
2016-04-29 19:21 ` Stephen Warren
2016-05-01 19:16 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 39/60] ARM: tegra: remove get_num_cpus() Stephen Warren
2016-04-19 20:59 ` [U-Boot] [PATCH 40/60] ARM: tegra: remove gp_padctrl.h Stephen Warren
2016-05-07 22:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 41/60] ARM: tegra: remove tegra_get_sku_info() Stephen Warren
2016-05-07 22:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 42/60] ARM: tegra: move EMC code to tegra20/ directory Stephen Warren
2016-05-07 22:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 43/60] ARM: tegra: move PLLX configuration into SoC directories Stephen Warren
2016-05-07 22:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 44/60] ARM: tegra: remove tegra_get_chip_sku() Stephen Warren
2016-05-07 22:31 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 45/60] ARM: tegra: move custom pinmux.h to <mach/> Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 46/60] ARM: tegra: add pinmux APIs to replace funcmux Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 47/60] ARM: tegra: provide API for SPL code to init UART Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 48/60] ARM: tegra: lay groundwork for board hook cleanup Stephen Warren
2016-04-19 20:59 ` [U-Boot] [PATCH 49/60] ARM: tegra: convert boards to new hooks Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 50/60] ARM: tegra: remove unused includes Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 51/60] ARM: tegra: move SPL-specific GPIO device to spl.c Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 52/60] ARM: tegra: convert pin_mux_*() to new hooks Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 53/60] tegra: keyboard: move pinmux setup to board files Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 54/60] video: tegra: " Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 55/60] i2c: " Stephen Warren
2016-04-27 15:12 ` Simon Glass
2016-04-27 16:24 ` Stephen Warren
2016-04-27 16:58 ` Simon Glass
2016-04-27 17:16 ` Stephen Warren
2016-04-29 14:02 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 56/60] ARM: tegra: remove funcmux API Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 57/60] ARM: tegra: don't access Boot Info Table from board code Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 58/60] ARM: tegra: clean up board include statements Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 59/60] ARM: tegra: unify+move tegra.h to mach-tegra/ Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-04-19 20:59 ` [U-Boot] [PATCH 60/60] ARM: tegra: move clock headers Stephen Warren
2016-05-07 22:32 ` Simon Glass
2016-05-07 22:32 ` [U-Boot] [PATCH 00/60] ARM: tegra: cleanup part 1 Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571FD328.50301@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox