From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dinh Nguyen Date: Wed, 27 Apr 2016 12:15:04 -0500 Subject: [U-Boot] [PATCH] usb: dwc2: Init desc_before_addr In-Reply-To: <1461632904-6909-1-git-send-email-marex@denx.de> References: <1461632904-6909-1-git-send-email-marex@denx.de> Message-ID: <5720F398.1020104@opensource.altera.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/25/2016 08:08 PM, Marek Vasut wrote: > Initialize desc_before_addr, otherwise the USB core won't send the > first 64B Get Device Descriptor request in common/usb.c function > usb_setup_descriptor() . There are some USB devices which expect > this sequence and otherwise can misbehave. > > Signed-off-by: Marek Vasut > Cc: Dinh Nguyen > Cc: Tom Rini > --- > drivers/usb/host/dwc2.c | 3 +++ > 1 file changed, 3 insertions(+) > --- > NOTE: I checked this with TotalPhase Beagle USB480 and it does what it is > supposed to do now. It would be wonderful to get this into rc3. > > diff --git a/drivers/usb/host/dwc2.c b/drivers/usb/host/dwc2.c > index b2f4bc6..559c43f 100644 > --- a/drivers/usb/host/dwc2.c > +++ b/drivers/usb/host/dwc2.c > @@ -1182,6 +1182,9 @@ static int dwc2_usb_ofdata_to_platdata(struct udevice *dev) > static int dwc2_usb_probe(struct udevice *dev) > { > struct dwc2_priv *priv = dev_get_priv(dev); > + struct usb_bus_priv *bus_priv = dev_get_uclass_priv(dev); > + > + bus_priv->desc_before_addr = true; > > return dwc2_init_common(priv); > } > With this patch, I no longer have to revert commit "c998da0d67091 usb: Change power-on / scanning timeout handling" for my problematic Kingston USB stick to work. So feel free to add: Tested-by: Dinh Nguyen Dinh