From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fs: ext4: fix symlink read function
Date: Wed, 27 Apr 2016 11:34:31 -0600 [thread overview]
Message-ID: <5720F827.9090508@wwwdotorg.org> (raw)
In-Reply-To: <1461775250-29762-1-git-send-email-sr@denx.de>
On 04/27/2016 10:40 AM, Stefan Roese wrote:
> From: Ronald Zachariah <rozachar@cisco.com>
>
> The function ext4fs_read_symlink was unable to handle a symlink
> which had target name of exactly 60 characters.
Reviewed-by: Stephen Warren <swarren@nvidia.com>
This seems to match how the Linux kernel encodes symlinks.
> - if (__le32_to_cpu(diro->inode.size) <= 60) {
> + if (__le32_to_cpu(diro->inode.size) < 60) {
It'd be nice if "60" was replaced with sizeof(diro->inode.b.symlink),
but that's probably a topic for a different patch.
next prev parent reply other threads:[~2016-04-27 17:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 16:40 [U-Boot] [PATCH] fs: ext4: fix symlink read function Stefan Roese
2016-04-27 17:34 ` Stephen Warren [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-09-07 9:20 Gary Bisson
2015-09-08 3:56 ` Simon Glass
2015-09-08 8:30 ` Gary Bisson
2015-09-09 18:08 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5720F827.9090508@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox