From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Wed, 27 Apr 2016 11:34:31 -0600 Subject: [U-Boot] [PATCH] fs: ext4: fix symlink read function In-Reply-To: <1461775250-29762-1-git-send-email-sr@denx.de> References: <1461775250-29762-1-git-send-email-sr@denx.de> Message-ID: <5720F827.9090508@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/27/2016 10:40 AM, Stefan Roese wrote: > From: Ronald Zachariah > > The function ext4fs_read_symlink was unable to handle a symlink > which had target name of exactly 60 characters. Reviewed-by: Stephen Warren This seems to match how the Linux kernel encodes symlinks. > - if (__le32_to_cpu(diro->inode.size) <= 60) { > + if (__le32_to_cpu(diro->inode.size) < 60) { It'd be nice if "60" was replaced with sizeof(diro->inode.b.symlink), but that's probably a topic for a different patch.