public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Angelo Dureghello <angelo@sysam.it>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/2] m68k: add DM model serial driver
Date: Wed, 27 Apr 2016 22:02:01 +0200	[thread overview]
Message-ID: <57211AB9.2030309@sysam.it> (raw)
In-Reply-To: <CAPnjgZ1rGJm_iHfihbUkS0c5h9_3U1K4MemEvFiAgh2Jka2K6w@mail.gmail.com>

Hi Simon,

sent v4.

Tested

- legacy serial driver and DM serial driver in mcf5307 "amcore" board
- buildman, pass all boards
- checkpatch

Regards,
angelo


On 26/04/2016 17:26, Simon Glass wrote:
> Hi Angelo,
>
> On 26 April 2016 at 03:03, Angelo Dureghello <angelo@sysam.it> wrote:
>>
>> Hi Simon,
>>
>> i realized this patch (v3) is invalid, due to my tests done with "CONFIG_DM_SRIAL" (missing 'A'), so was using the legacy driver still.
>>
>> Also, i found a small issue in start.S files.
>>
>> I send v4 asap later.
>
> OK, thank you. I'll look out for it.
>
> Regards,
> Simon
>
>>
>> thanks,
>>
>> regards,
>> Angelo Dureghello
>>
>>
>>
>> On 25/04/2016 23:54, Simon Glass wrote:
>>>
>>> Hi Angelo,
>>>
>>> On 24 April 2016 at 16:20, Angelo Dureghello <angelo@sysam.it> wrote:
>>>>
>>>> Boards can now use DM serial driver, or still legacy mcf uart
>>>> driver version.
>>>>
>>>> Signed-off-by: Angelo Dureghello <angelo@sysam.it>
>>>> ---
>>>> Changes for v2:
>>>>      - remove while loops in putc and getc, replacing with return -EAGAIN
>>>>      - remove unneeded ifdef
>>>> Changes for v3:
>>>>      - no changes
>>>> ---
>>>>    drivers/serial/mcfuart.c | 188 ++++++++++++++++++++++++++++++++++++-----------
>>>>    1 file changed, 144 insertions(+), 44 deletions(-)
>>>>
>>>
>>> Missing file?
>>>
>>> 02: dm: gpio: pca953x: introduce driver model support for pca953x
>>> 03: m68k: add malloc memory for early malloc
>>> 04: m68k: add DM model serial driver
>>>         m68k:  +   M5329AFEE M5249EVB M5208EVBE M5475FFE M54451EVB
>>> astro_mcf5373l M54418TWR_serial_rmii M54455EVB_intel amcore M5282EVB
>>> M54455EVB_i66 M54455EVB_a66 M5475GFE M5485GFE M5253DEMO
>>> M54455EVB_stm33 M5475AFE M54455EVB M5485BFE M5329BFEE M52277EVB
>>> M5475EFE M54418TWR_nand_mii M5475CFE cobra5272 M5485AFE M5485HFE
>>> M54418TWR_nand_rmii_lowfreq M5485DFE M5475DFE M5275EVB M54418TWR
>>> M52277EVB_stmicro eb_cpu5282 eb_cpu5282_internal M53017EVB M5485CFE
>>> M5475BFE M5485EFE M5253EVBE M5485FFE M5235EVB_Flash32 M5373EVB
>>> M54418TWR_nand_rmii M54418TWR_serial_mii M5235EVB M54451EVB_stmicro
>>> M5272C3
>>> +../drivers/serial/mcfuart.c:18:46: fatal error:
>>> dm/platform_data/serial_coldfire.h: No such file or directory
>>> + #include <dm/platform_data/serial_coldfire.h>
>>> +                                              ^
>>> +compilation terminated.
>>> +make[2]: *** [drivers/serial/mcfuart.o] Error 1
>>> +make[1]: *** [drivers/serial] Error 2
>>>
>>> Regards,
>>> Simon
>>>

      reply	other threads:[~2016-04-27 20:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-24 22:20 [U-Boot] [PATCH v3 2/2] m68k: add DM model serial driver Angelo Dureghello
2016-04-25 21:54 ` Simon Glass
2016-04-26  9:03   ` Angelo Dureghello
2016-04-26 15:26     ` Simon Glass
2016-04-27 20:02       ` Angelo Dureghello [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57211AB9.2030309@sysam.it \
    --to=angelo@sysam.it \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox