public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: socfpga: Add samtec VIN|ING board
Date: Thu, 28 Apr 2016 01:49:38 +0200	[thread overview]
Message-ID: <57215012.8060509@denx.de> (raw)
In-Reply-To: <570EBFE8.1000307@opensource.altera.com>

On 04/13/2016 11:53 PM, Dinh Nguyen wrote:
> On 04/13/2016 07:24 AM, Marek Vasut wrote:
>> Add support for board based on the popular Altera Cyclone V SoC.
>> This board has the following properties:
>>  - 1 GiB of DRAM
>>  - 1 Gigabit ethernet
>>  - 1 USB gadget port
>>  - 1 USB host port with an on-board hub
>>  - 2 QSPI NORs connected to the Cadence QSPI core
>>  - Multiple I2C EEPROMs and one I2C temperature sensor
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
>> Cc: Chin Liang See <clsee@altera.com>
>> ---
> 
> [snip]
> 
>> --- /dev/null
>> +++ b/include/configs/socfpga_vining_fpga.h
>> @@ -0,0 +1,246 @@
>> +/*
>> + * Copyright (C) 2015 Marek Vasut <marex@denx.de>
>> + *
>> + * SPDX-License-Identifier:	GPL-2.0+
>> + */
>> +#ifndef __CONFIG_SAMTEC_VINING_FPGA_H__
>> +#define __CONFIG_SAMTEC_VINING_FPGA_H__
>> +
>> +#include <asm/arch/base_addr_ac5.h>
>> +
>> +/* U-Boot Commands */
>> +#define CONFIG_SYS_NO_FLASH
>> +#define CONFIG_DOS_PARTITION
>> +#define CONFIG_FAT_WRITE
>> +#define CONFIG_HW_WATCHDOG
>> +
>> +#define CONFIG_CMD_ASKENV
>> +#define CONFIG_CMD_BOOTZ
>> +#define CONFIG_CMD_CACHE
>> +#define CONFIG_CMD_DFU
>> +#define CONFIG_CMD_DHCP
>> +#define CONFIG_CMD_EEPROM
>> +#define CONFIG_CMD_EXT4
>> +#define CONFIG_CMD_EXT4_WRITE
>> +#define CONFIG_CMD_FAT
>> +#define CONFIG_CMD_FS_GENERIC
>> +#define CONFIG_CMD_GREPENV
>> +#define CONFIG_CMD_LED
>> +#define CONFIG_CMD_MII
>> +#define CONFIG_CMD_MMC
>> +#define CONFIG_CMD_PING
>> +#define CONFIG_CMD_USB
>> +#define CONFIG_CMD_USB_MASS_STORAGE
>> +
> 
> With my patch[1], you don't need all of those common configs, all you
> need is:
> 
> #define CONFIG_CMD_DFU
> #define CONFIG_CMD_USB
> #define CONFIG_CMD_USB_MASS_STORAGE

Well since there are changes in that, are you fine if I pick this board
as-is for next ?

-- 
Best regards,
Marek Vasut

  parent reply	other threads:[~2016-04-27 23:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13 12:24 [U-Boot] [PATCH] arm: socfpga: Add samtec VIN|ING board Marek Vasut
2016-04-13 21:53 ` Dinh Nguyen
2016-04-13 22:08   ` Marek Vasut
2016-04-27 23:49   ` Marek Vasut [this message]
2016-04-28  0:57     ` Tom Rini
2016-04-28  1:26       ` Marek Vasut
2016-04-28 13:36     ` Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57215012.8060509@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox