public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH] dm: ensure device names are unique
Date: Thu, 28 Apr 2016 09:55:32 -0600	[thread overview]
Message-ID: <57223274.6010104@wwwdotorg.org> (raw)
In-Reply-To: <CAPnjgZ0GQ1-CYTEMEsyHYN7m7gDxGrT99adJEXq0F1MfdGZS+Q@mail.gmail.com>

On 04/27/2016 10:50 PM, Simon Glass wrote:
> Hi Stephen,
>
> On 26 April 2016 at 15:30, Stephen Warren wrote:
>  > It is possible for HW to contain multiple instances of the same device. In
>  > this case, the name passed to device_bind() may not be unique across all
>  > devices within its uclass. One example is a system with multiple  identical
>  > PCI Ethernet devices. Another might be a system with multiple identical
>  > I2C GPIO expanders, each connected to a separate I2C bus, yet using the
>  > same I2C address on that bus and hence having the same DT node name.
>  >
>  > Enhance the code to detect this situation, and append a sequence  number so
>  > the device name to ensure uniqueness.
>  >
>  > Signed-off-by: Stephen Warren <swarren at nvidia.com <swarren@nvidia.com>>
>
> I would rather that the caller handles this. But failing this perhaps a
> new function that does it? Is this for the Ethernet use case?

Wouldn't all callers of this function simply call the new function? I'm 
not aware of any case where the code to avoid duplicate names would not 
be desired.

I hit this for the Ethernet case, but I believe it applies to any type 
of device at all; see another possible trigger case in the commit 
description.

  reply	other threads:[~2016-04-28 15:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26 21:30 [U-Boot] [RFC PATCH] dm: ensure device names are unique Stephen Warren
2016-04-26 21:36 ` Stephen Warren
2016-04-27 18:40   ` Stephen Warren
2016-04-28  4:44     ` Joe Hershberger
2016-04-28  4:42 ` Joe Hershberger
2016-04-28 16:00   ` Stephen Warren
2016-04-29 13:24     ` Simon Glass
2016-04-28  4:50 ` Simon Glass
2016-04-28 15:55   ` Stephen Warren [this message]
2016-04-29 13:23     ` Simon Glass
2016-04-29 16:23       ` Stephen Warren
2016-04-29 16:28         ` Simon Glass
2016-04-29 16:30           ` Stephen Warren
2016-04-29 17:22             ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57223274.6010104@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox