public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vignesh R <vigneshr@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] mtd: cqspi: Simplify indirect write code
Date: Fri, 29 Apr 2016 11:33:21 +0530	[thread overview]
Message-ID: <5722F929.7070200@ti.com> (raw)
In-Reply-To: <1461796606-9254-1-git-send-email-marex@denx.de>



On 04/28/2016 04:06 AM, Marek Vasut wrote:
> The indirect write code is buggy pile of nastiness which fails horribly
> when the system runs fast enough to saturate the controller. The failure
> results in some pages (256B) not being written to the flash. This can be
> observed on systems which run with Dcache enabled and L2 cache enabled,
> like the Altera SoCFPGA.
> 
> This patch replaces the whole unmaintainable indirect write implementation
> with the one from upcoming Linux CQSPI driver, which went through multiple
> rounds of thorough review and testing. While this makes the patch look
> terrifying and violates all best-practices of software development, all
> the patch does is it plucks out duplicate ad-hoc code distributed across
> the driver and replaces it with more compact code doing exactly the same
> thing.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Anatolij Gustschin <agust@denx.de>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> Cc: Jagan Teki <jteki@openedev.com>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Vignesh R <vigneshr@ti.com>
> ---

Tested on K2G EVM that has Cadence QSPI controller and s25fl512s
Spansion flash
For both the patches:

Tested-by: Vignesh R <vigneshr@ti.com>



-- 
Regards
Vignesh

  parent reply	other threads:[~2016-04-29  6:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-27 22:36 [U-Boot] [PATCH 1/2] mtd: cqspi: Simplify indirect write code Marek Vasut
2016-04-27 22:36 ` [U-Boot] [PATCH 2/2] mtd: cqspi: Simplify indirect read code Marek Vasut
2016-04-29  6:03 ` Vignesh R [this message]
2016-04-29  9:35 ` [U-Boot] [PATCH 1/2] mtd: cqspi: Simplify indirect write code Stefan Roese
2016-04-29 10:13   ` Marek Vasut
2016-05-02 15:20     ` Stefan Roese
2016-05-03 16:53       ` Marek Vasut
2016-05-03 17:00         ` Stefan Roese
2016-05-03 17:18           ` Marek Vasut
2016-05-04  8:59             ` Stefan Roese
2016-05-03 10:42 ` Pavel Machek
2016-05-03 10:46   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5722F929.7070200@ti.com \
    --to=vigneshr@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox