From: Mugunthan V N <mugunthanvnm@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 06/12] drivers: net: cpsw: add support for reading mac address from efuse
Date: Fri, 29 Apr 2016 11:34:35 +0530 [thread overview]
Message-ID: <5722F973.4010207@ti.com> (raw)
In-Reply-To: <CANr=Z=btWeMzDvWfvaizbyGQMB_VWqicxcHETyTxjO-fHPMN5w@mail.gmail.com>
On Thursday 28 April 2016 10:01 AM, Joe Hershberger wrote:
> On Wed, Apr 27, 2016 at 1:33 AM, Mugunthan V N <mugunthanvnm@ti.com> wrote:
>> On Wednesday 27 April 2016 03:06 AM, Joe Hershberger wrote:
>>> On Mon, Apr 25, 2016 at 4:53 PM, Joe Hershberger
>>> <joe.hershberger@gmail.com> wrote:
>>>> On Tue, Apr 12, 2016 at 3:46 AM, Mugunthan V N <mugunthanvnm@ti.com> wrote:
>>>>> Different TI platforms has to read with different combination to
>>>>> get the mac address from efuse. So add support to read mac address
>>>>> based on machine/device compatibles.
>>>>>
>>>>> The code is taken from Linux drivers/net/ethernet/ti/cpsw-common.c
>>>>> done by Tony Lindgren.
>>>>>
>>>>> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
>>>>
>>>> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
>>>
>>> This is not checkpatch.pl clean. Please resubmit.
>>>
>>> 609306.mbox:92: WARNING: line over 80 characters
>>> 609306.mbox:132: WARNING: line over 80 characters
>>>
>>
>> WARNING: line over 80 characters
>> #103: FILE: drivers/net/cpsw-common.c:39:
>> + error("Not able to get syscon address to get mac efuse address\n");
>>
>> WARNING: line over 80 characters
>> #143: FILE: drivers/net/cpsw-common.c:79:
>> + error("Not able to get syscon address to get mac efuse address\n");
>>
>> total: 0 errors, 2 warnings, 0 checks, 184 lines checked
>>
>> These warnings are from error logs which can be ignored as it makes life
>> easier to grep the source when issue is found. The same is followed in
>> kernel as well.
>
> OK. Please address the other patch as well. Are all failures
> justifiable for the same reason?
>
I just reposted the v3 of this patches with rebase to u-boot/master.
I get only the above two checkpatch warning for the whole series, is
there some other warning else you get in your testing?
Regards
Mugunthan V N
next prev parent reply other threads:[~2016-04-29 6:04 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 8:46 [U-Boot] [PATCH v2 00/12] cpsw: enable DM_ETH on dra74 and am437x evms Mugunthan V N
2016-04-12 8:46 ` [U-Boot] [PATCH v2 01/12] drivers: core: device: add support to check dt compatible for a device/machine Mugunthan V N
2016-04-25 21:59 ` Joe Hershberger
2016-04-12 8:46 ` [U-Boot] [PATCH v2 02/12] ti_omap5_common: eth: do not define DM_ETH for spl Mugunthan V N
2016-04-25 21:54 ` Joe Hershberger
2016-04-12 8:46 ` [U-Boot] [PATCH v2 03/12] drivers: net: cpsw: fix cpsw dp parse when num slaves as 1 Mugunthan V N
2016-04-25 22:00 ` Joe Hershberger
2016-04-12 8:46 ` [U-Boot] [PATCH v2 04/12] ARM: omap5: add platform specific ethernet phy modes configurations Mugunthan V N
2016-04-25 22:00 ` Joe Hershberger
2016-04-12 8:46 ` [U-Boot] [PATCH v2 05/12] drivers: net: cpsw: fix get mdio base and gmii_sel reg from DT Mugunthan V N
2016-04-12 17:23 ` Tom Rini
2016-04-25 21:51 ` Joe Hershberger
2016-04-12 8:46 ` [U-Boot] [PATCH v2 06/12] drivers: net: cpsw: add support for reading mac address from efuse Mugunthan V N
2016-04-12 17:23 ` Tom Rini
2016-04-25 21:53 ` Joe Hershberger
2016-04-26 21:36 ` Joe Hershberger
2016-04-27 6:33 ` Mugunthan V N
2016-04-28 4:31 ` Joe Hershberger
2016-04-29 6:04 ` Mugunthan V N [this message]
2016-04-12 8:46 ` [U-Boot] [PATCH v2 07/12] arm: dts: am4372: add syscon node to cpsw to read mac address Mugunthan V N
2016-04-25 22:01 ` Joe Hershberger
2016-04-12 8:46 ` [U-Boot] [PATCH v2 08/12] arm: dts: dra7: " Mugunthan V N
2016-04-25 22:01 ` Joe Hershberger
2016-04-12 8:46 ` [U-Boot] [PATCH v2 09/12] arm: dts: dra7: fix ethernet name with proper device address Mugunthan V N
2016-04-12 17:23 ` Tom Rini
2016-04-13 5:18 ` Mugunthan V N
2016-04-25 22:49 ` Joe Hershberger
2016-04-12 8:46 ` [U-Boot] [PATCH v2 10/12] defconfig: am437x_gp_evm: enable eth driver model Mugunthan V N
2016-04-25 22:01 ` Joe Hershberger
2016-04-26 21:38 ` Joe Hershberger
2016-04-27 6:37 ` Mugunthan V N
2016-04-28 4:33 ` Joe Hershberger
2016-04-28 8:54 ` Mugunthan V N
2016-04-12 8:46 ` [U-Boot] [PATCH v2 11/12] defconfig: am437x_sk_evm: " Mugunthan V N
2016-04-25 22:01 ` Joe Hershberger
2016-04-26 21:39 ` Joe Hershberger
2016-04-12 8:46 ` [U-Boot] [PATCH v2 12/12] defconfig: dra74_evm: " Mugunthan V N
2016-04-25 22:01 ` Joe Hershberger
2016-04-26 21:39 ` Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5722F973.4010207@ti.com \
--to=mugunthanvnm@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox