From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] ARM: exynos: Disable serial support in SPL
Date: Sun, 01 May 2016 21:46:46 +0200 [thread overview]
Message-ID: <57265D26.4030305@denx.de> (raw)
In-Reply-To: <20160501185720.GG7884@bill-the-cat>
On 05/01/2016 08:57 PM, Tom Rini wrote:
> On Sun, May 01, 2016 at 12:36:12AM +0200, Marek Vasut wrote:
>
>> The exynos5 platforms use DM in U-Boot and do not use DM in SPL. The serial
>> driver, serial_s5p.c, is DM-only. This is OK for U-Boot, but in SPL, this
>> will fail with the following compile error:
>>
>> drivers/built-in.o: In function `get_current':
>> ...u-boot/drivers/serial/serial.c:387: undefined reference to `default_serial_console'
>>
>> This warning happens because common/console.c is compiled into U-Boot SPL
>> if CONFIG_SPL_SERIAL_SUPPORT . The common/console.c invokes serial_*()
>> functions and since exynos5 does not use DM in SPL, these functions come
>> from drivers/serial/serial.c . The serial_*() locate default serial port
>> by calling default_serial_console(), but because the serial_s5p.c is DM-only,
>> it does no longer define default_serial_console(). Thus the error.
>
> This is OK short term
Yes, indeed.
> can you see if turning on DM in SPL is easy for
> these platforms instead? Thanks!
>
I hope Simon can take a look into that ;-)
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-05-01 19:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-30 22:36 [U-Boot] [PATCH 1/2] ARM: exynos: Fix build error if SERIAL is disabled in SPL Marek Vasut
2016-04-30 22:36 ` [U-Boot] [PATCH 2/2] ARM: exynos: Disable serial support " Marek Vasut
2016-05-01 18:55 ` Simon Glass
2016-05-01 18:57 ` Tom Rini
2016-05-01 19:46 ` Marek Vasut [this message]
2016-05-26 5:01 ` Minkyu Kang
2016-05-01 18:55 ` [U-Boot] [PATCH 1/2] ARM: exynos: Fix build error if SERIAL is disabled " Simon Glass
2016-05-26 5:01 ` Minkyu Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57265D26.4030305@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox