From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 03/18] bootm: Align cache flush end address correctly
Date: Tue, 3 May 2016 09:51:06 +0200 [thread overview]
Message-ID: <5728586A.3040700@denx.de> (raw)
In-Reply-To: <1462257612-28746-4-git-send-email-sjg@chromium.org>
Hello Simon,
Am 03.05.2016 um 08:39 schrieb Simon Glass:
> Flushing part of the cache should be done on cache boundaries. Trying to
> flush part of a cache line is not supported and the request may be ignored
> or print warnings.
>
> Adjust the bootm code to align the end address to prevent this problem.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> common/bootm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks!
Reviewed-by: Heiko Schocher <hs@denx.de>
tested on the smartweb, corvus, taurus and axm board
Tested-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
>
> diff --git a/common/bootm.c b/common/bootm.c
> index c965326..7469c61 100644
> --- a/common/bootm.c
> +++ b/common/bootm.c
> @@ -435,7 +435,7 @@ static int bootm_load_os(bootm_headers_t *images, unsigned long *load_end,
> bootstage_error(BOOTSTAGE_ID_DECOMP_IMAGE);
> return err;
> }
> - flush_cache(load, *load_end - load);
> + flush_cache(load, ALIGN(*load_end - load, ARCH_DMA_MINALIGN));
>
> debug(" kernel loaded at 0x%08lx, end = 0x%08lx\n", load, *load_end);
> bootstage_mark(BOOTSTAGE_ID_KERNEL_LOADED);
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2016-05-03 7:51 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 6:39 [U-Boot] [PATCH 00/18] at91: Convert Ethernet and LCD to driver model Simon Glass
2016-05-03 6:39 ` [U-Boot] [PATCH 01/18] at91: Add support for the AT91 slow clock controller Simon Glass
2016-05-03 7:48 ` Heiko Schocher
2016-05-05 13:24 ` Andreas Bießmann
2016-05-03 6:39 ` [U-Boot] [PATCH 02/18] arm: Allow skipping of low-level init with I-cache on Simon Glass
2016-05-03 7:50 ` Heiko Schocher
2016-05-03 19:37 ` Joe Hershberger
2016-05-03 6:39 ` [U-Boot] [PATCH 03/18] bootm: Align cache flush end address correctly Simon Glass
2016-05-03 7:51 ` Heiko Schocher [this message]
2016-05-03 19:39 ` Joe Hershberger
2016-05-03 6:39 ` [U-Boot] [PATCH 04/18] net: Handle an empty bootp extension section Simon Glass
2016-05-03 19:36 ` Joe Hershberger
2016-05-03 6:39 ` [U-Boot] [PATCH 05/18] net: macb: Prepare for driver-model conversion Simon Glass
2016-05-03 7:52 ` Heiko Schocher
2016-05-03 19:45 ` Joe Hershberger
2016-05-03 6:40 ` [U-Boot] [PATCH 06/18] net: macb: Flush correct cache portion when sending Simon Glass
2016-05-03 7:53 ` Heiko Schocher
2016-05-03 19:54 ` Joe Hershberger
2016-05-03 6:40 ` [U-Boot] [PATCH 07/18] net: macb: Convert to driver model Simon Glass
2016-05-03 7:53 ` Heiko Schocher
2016-05-04 7:29 ` Yang, Wenyou
2016-05-04 7:32 ` Yang, Wenyou
2016-05-05 2:38 ` Simon Glass
2016-05-05 3:15 ` Yang, Wenyou
2016-05-05 3:18 ` Simon Glass
2016-05-05 3:37 ` Yang, Wenyou
2016-05-05 17:19 ` Simon Glass
2016-05-06 7:10 ` Yang, Wenyou
2016-05-03 20:54 ` Joe Hershberger
2016-05-05 2:38 ` Simon Glass
2016-05-03 6:40 ` [U-Boot] [PATCH 08/18] arm: at91: dts: Bring in device tree file for AT91SAM9G45 Simon Glass
2016-05-03 8:23 ` Heiko Schocher
2016-05-03 6:40 ` [U-Boot] [PATCH 09/18] arm: at91: Add a header file for the real-time clock Simon Glass
2016-05-03 8:30 ` Heiko Schocher
2016-05-03 6:40 ` [U-Boot] [PATCH 10/18] at91: Correct NAND ECC register access Simon Glass
2016-05-03 6:40 ` [U-Boot] [PATCH 11/18] at91: nand: Set up the ECC strength correctly Simon Glass
2016-05-03 6:40 ` [U-Boot] [PATCH 12/18] mtd: nand: Drop a blank line in nand_wait() Simon Glass
2016-05-03 6:40 ` [U-Boot] [PATCH 13/18] at91: Add driver-model GPIO devices for AT91SAM9G45 Simon Glass
2016-05-03 8:31 ` Heiko Schocher
2016-05-03 6:40 ` [U-Boot] [PATCH 14/18] at91: mtd: nand: Add dev_warn() to correct build error in driver Simon Glass
2016-05-03 6:40 ` [U-Boot] [PATCH 15/18] at91: video: Prepare for driver-model conversion Simon Glass
2016-05-03 6:40 ` [U-Boot] [PATCH 16/18] at91: video: Support driver-model for the LCD driver Simon Glass
2016-05-03 6:40 ` [U-Boot] [PATCH 17/18] fdt: Correct return value in fdtdec_decode_display_timing() Simon Glass
2016-05-03 6:40 ` [U-Boot] [PATCH 18/18] arm: at91: Add support for gurnard Simon Glass
2016-05-05 2:42 ` [U-Boot] [PATCH 00/18] at91: Convert Ethernet and LCD to driver model Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5728586A.3040700@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox