[U-Boot] [PATCH 07/18] net: macb: Convert to driver model

Simon Glass
2016-05-05T02:38:14Z

Hi,

On 4 May 2016 at 01:32, Yang, Wenyou <Wenyou.Yang@atmel.com> wrote:
>
> Hi
>
> > -----Original Message-----
> > From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Heiko
> > Schocher
> > Sent: 2016?5?3? 15:54
> > To: Simon Glass <sjg@chromium.org>
> > Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Joe Hershberger
> > <joe.hershberger@ni.com>
> > Subject: Re: [U-Boot] [PATCH 07/18] net: macb: Convert to driver model
> >
> > Hello Simon,
> >
> > Am 03.05.2016 um 08:40 schrieb Simon Glass:
> > > Add driver-model support to this driver. The old code remains for now
> > > so that we can convert boards one at a time.
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > > ---
> > >
> > > drivers/net/macb.c | 119
> > +++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > 1 file changed, 119 insertions(+)
> >
> > Thanks!
> >
> > Reviewed-by: Heiko Schocher <hs@denx.de>
> >
> > tested on the smartweb, corvus, taurus and axm board
> >
> > Tested-by: Heiko Schocher <hs@denx.de>
>
> I tried to test this patch series on SAMA5D2 Xplained board, but I have the compile warning below. Did you experience it?
>
> ---8<---------
> drivers/net/macb.c: In function 'macb_phy_init':
> drivers/net/macb.c:487:9: warning: passing argument 3 of 'phy_connect' from incompatible pointer type [enabled by default]
> In file included from include/miiphy.h:22:0,
> from drivers/net/macb.c:36:
> include/phy.h:226:20: note: expected 'struct udevice *' but argument is of type 'const struct device **'
> --->8--------

No I don't see that problem. I did a full build test. What is the
board config name you are using?
>
> Thanks.
>
> >
> > bye,
> > Heiko
> > --
> > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
>
>
> Best Regards,
> Wenyou Yang

Regards,
Simon