public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 04/26] x86: irq: Reserve IRQ9 for ACPI in PIC mode
Date: Tue, 3 May 2016 14:29:42 +0200	[thread overview]
Message-ID: <572899B6.2070500@denx.de> (raw)
In-Reply-To: <1462174426-3470-5-git-send-email-bmeng.cn@gmail.com>

Hi Bin,

On 02.05.2016 09:33, Bin Meng wrote:
> Reserve IRQ9 which is to be used as SCI interrupt number
> for ACPI in PIC mode.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
>   arch/x86/cpu/irq.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/arch/x86/cpu/irq.c b/arch/x86/cpu/irq.c
> index 2950783..ae90b0c 100644
> --- a/arch/x86/cpu/irq.c
> +++ b/arch/x86/cpu/irq.c
> @@ -120,6 +120,10 @@ static int create_pirq_routing_table(struct udevice *dev)
>
>   	priv->irq_mask = fdtdec_get_int(blob, node,
>   					"intel,pirq-mask", PIRQ_BITMAP);
> +#ifdef CONFIG_GENERATE_ACPI_TABLE
> +	/* Reserve IRQ9 for SCI */
> +	priv->irq_mask &= ~(1 << 9);
> +#endif

Does it make sense to change this into using IS_ENABLED()?

	if (IS_ENABLED(CONFIG_GENERATE_ACPI_TABLE)) {
		/* Reserve IRQ9 for SCI */
		priv->irq_mask &= ~(1 << 9);
	}

To drop the #ifdef here?

Thanks,
Stefan

  reply	other threads:[~2016-05-03 12:29 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-02  7:33 [U-Boot] [PATCH 00/26] x86: Initial ACPI support for Intel BayTrail Bin Meng
2016-05-02  7:33 ` [U-Boot] [PATCH 01/26] x86: Drop asm/acpi.h Bin Meng
2016-05-02  7:33 ` [U-Boot] [PATCH 02/26] x86: Fix build warning in tables.c when CONFIG_SEABIOS Bin Meng
2016-05-02  7:33 ` [U-Boot] [PATCH 03/26] x86: acpi: Fix compiler warnings in write_acpi_tables() Bin Meng
2016-05-02  7:33 ` [U-Boot] [PATCH 04/26] x86: irq: Reserve IRQ9 for ACPI in PIC mode Bin Meng
2016-05-03 12:29   ` Stefan Roese [this message]
2016-05-03 12:46     ` Bin Meng
2016-05-03 13:04       ` Stefan Roese
2016-05-02  7:33 ` [U-Boot] [PATCH 05/26] x86: irq: Enable SCI on IRQ9 Bin Meng
2016-05-03 12:31   ` Stefan Roese
2016-05-07 14:06     ` Bin Meng
2016-05-07 15:42       ` Stefan Roese
2016-05-07 15:46         ` Bin Meng
2016-05-07 15:51           ` Stefan Roese
2016-05-07 18:46   ` Simon Glass
2016-05-02  7:33 ` [U-Boot] [PATCH 06/26] x86: dts: Update to include ACTL register details Bin Meng
2016-05-02  7:33 ` [U-Boot] [PATCH 07/26] acpi: Change build log for ASL files Bin Meng
2016-05-02  7:33 ` [U-Boot] [PATCH 08/26] acpi: Explicitly spell out dsdt.c in the make rule Bin Meng
2016-05-02  7:33 ` [U-Boot] [PATCH 09/26] acpi: Specify U-Boot include path for ASL files Bin Meng
2016-05-02  7:33 ` [U-Boot] [PATCH 10/26] acpi: Do not disable all errors/warnings/remarks when compiling ASL Bin Meng
2016-05-02  7:33 ` [U-Boot] [PATCH 11/26] x86: acpi: Remove unneeded codes Bin Meng
2016-05-03 12:33   ` Stefan Roese
2016-05-02  7:33 ` [U-Boot] [PATCH 12/26] x86: acpi: Various changes to acpi_table.h Bin Meng
2016-05-02  7:33 ` [U-Boot] [PATCH 13/26] x86: acpi: Reorder codes in acpi_table.h Bin Meng
2016-05-03 12:45   ` Stefan Roese
2016-05-02  7:33 ` [U-Boot] [PATCH 14/26] x86: acpi: Remove acpi_create_ssdt_generator() Bin Meng
2016-05-02  7:33 ` [U-Boot] [PATCH 15/26] x86: acpi: Change fill_header() Bin Meng
2016-05-02  7:33 ` [U-Boot] [PATCH 16/26] x86: acpi: Adjust orders in acpi_table.c Bin Meng
2016-05-03 12:48   ` Stefan Roese
2016-05-02  7:33 ` [U-Boot] [PATCH 17/26] x86: acpi: Change table write routine signature to use u32 Bin Meng
2016-05-02  7:33 ` [U-Boot] [PATCH 18/26] x86: acpi: Align FACS table to a 64 byte boundary Bin Meng
2016-05-02  7:33 ` [U-Boot] [PATCH 19/26] x86: acpi: Add some generic ASL libraries Bin Meng
2016-05-02  7:33 ` [U-Boot] [PATCH 20/26] x86: baytrail: Add platform ASL files Bin Meng
2016-05-02  7:33 ` [U-Boot] [PATCH 21/26] x86: baytrail: Generate ACPI FADT/MADT tables Bin Meng
2016-05-03 12:52   ` Stefan Roese
2016-05-07  5:48     ` Bin Meng
2016-05-02  7:33 ` [U-Boot] [PATCH 22/26] x86: baytrail: Enable ACPI table generation for all boards Bin Meng
2016-05-02  7:33 ` [U-Boot] [PATCH 23/26] x86: baytrail: Add .gitignore for ACPI enabled boards Bin Meng
2016-05-02  7:33 ` [U-Boot] [PATCH 24/26] x86: Remove acpi=off boot parameter when ACPI is on Bin Meng
2016-05-02  7:33 ` [U-Boot] [PATCH 25/26] x86: doc: Minor update for accuracy Bin Meng
2016-05-02  7:33 ` [U-Boot] [PATCH 26/26] x86: doc: Document ACPI support Bin Meng
2016-05-03 13:01 ` [U-Boot] [PATCH 00/26] x86: Initial ACPI support for Intel BayTrail Stefan Roese
2016-05-06  1:14   ` Bin Meng
2016-05-06 13:16     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=572899B6.2070500@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox