From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Wed, 4 May 2016 07:15:58 +0200 Subject: [U-Boot] [PATCH v2 03/15] arm: Kconfig: Add support for AM43xx SoC specific Kconfig In-Reply-To: <20160428133820.GI3619@borg.dal.design.ti.com> References: <1461787759-31649-1-git-send-email-d-allred@ti.com> <1461787759-31649-4-git-send-email-d-allred@ti.com> <572191AB.9020809@denx.de> <20160428133820.GI3619@borg.dal.design.ti.com> Message-ID: <5729858E.8090403@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Andreas, Am 28.04.2016 um 15:38 schrieb Andreas Dannenberg: > Hi Heiko, > let me chime in here and address some of your points... Thanks ... Sorry, missed your email ... > On Thu, Apr 28, 2016 at 06:29:31AM +0200, Heiko Schocher wrote: >> Hello Daniel, >> >> Am 27.04.2016 um 22:09 schrieb Daniel Allred: >>> From: Madan Srinivas >>> >>> Adding support for AM43xx secure devices require the addition >>> of some SOC specific config options like the amount of memory >>> used by public ROM and the address of the entry point of u-boot >>> or SPL, as seen by the ROM code, for the image to be built >>> correctly. >>> >>> This mandates the addition of am AM43xx CONFIG option and the >>> ARM Kconfig file has been modified to source this SOC Kconfig >>> file. Moving the TARGET_AM43XX_EVM config option to the SOC >>> KConfig and out of the arch/arm/Kconfig. >>> >>> Updating defconfigs to add the CONFIG_AM43XX=y statement and >>> removing the #define CONFIG_AM43XX from the header file. >>> >>> Signed-off-by: Madan Srinivas >>> Signed-off-by: Daniel Allred >>> >>> Tested-by: Andreas Dannenberg >>> --- >>> >>> V2: >>> Update more defconfigs >>> Replace CREATE_BOARD_SYMLINK with TI_I2C_BOARD_DETECT >>> Rebase against latest master >>> >>> arch/arm/Kconfig | 19 +++++++++++++------ >>> arch/arm/cpu/armv7/am33xx/Kconfig | 13 +++++++++++++ >> ^^^^^^ >> Is this correct? > > AFAIK AM33xx and AM43xx have gotten lumped together in several places > both in U-Boot as well as in the Linux Kernel due to similarities in > architecture allowing for code re-use, almost like a "platform" even > though of course those are two different devices. I suppose because > AM33xx devices were first that's how the folder got its name original > name. > > If you look around in that folder and open some files you should see > some code such as in emif4.c where stuff is shared. Ah, yes, thanks. >>> configs/am437x_gp_evm_defconfig | 1 + >>> configs/am437x_sk_evm_defconfig | 1 + >>> configs/am43xx_evm_defconfig | 1 + >>> configs/am43xx_evm_ethboot_defconfig | 1 + >>> configs/am43xx_evm_qspiboot_defconfig | 1 + >>> configs/am43xx_evm_usbhost_boot_defconfig | 1 + >>> include/configs/am43xx_evm.h | 2 -- >>> 9 files changed, 32 insertions(+), 8 deletions(-) >> >> Thanks for your patchseries looks very interesting. >> >> May you have patches for am335x ? I ask, because I have an am335x based >> board, which also uses HS boot mode, so I can test your patches, and >> we can may sync our work. > > Generally speaking AM335x HS device support in public U-Boot is > currently not for us (us, meaning anybody including existing customers) > to publicly discuss but you can probably take a guess in which direction > things might go after these initial steps taken with Daniel's patch > series. If you have inputs/suggestions however please feel free to email > me directly and we can take it from there. Ok, thanks. >>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >>> index 6b65d8e..6577572 100644 >>> --- a/arch/arm/Kconfig >>> +++ b/arch/arm/Kconfig >>> @@ -381,12 +381,6 @@ config TARGET_AM335X_SL50 >>> select DM >>> select DM_SERIAL >>> >>> -config TARGET_AM43XX_EVM >>> - bool "Support am43xx_evm" >>> - select CPU_V7 >>> - select SUPPORT_SPL >>> - select TI_I2C_BOARD_DETECT >>> - >>> config TARGET_BAV335X >>> bool "Support bav335x" >>> select CPU_V7 >>> @@ -507,6 +501,17 @@ config OMAP54XX >>> select CPU_V7 >>> select SUPPORT_SPL >>> >>> +config AM43XX >>> + bool "AM43XX SoC" >>> + select CPU_V7 >>> + select SUPPORT_SPL >>> + help >>> + Support for AM43xx SOC from Texas Instruments. >>> + The AM43xx high performance SOC features a Cortex-A9 >>> + ARM core, a quad core PRU-ICSS for industrial Ethernet >>> + protocols, dual camera support, optional 3D graphics >>> + and an optional customer programmable secure boot. >>> + >>> config RMOBILE >>> bool "Renesas ARM SoCs" >>> select CPU_V7 >>> @@ -777,6 +782,8 @@ source "arch/arm/cpu/armv7/omap4/Kconfig" >>> >>> source "arch/arm/cpu/armv7/omap5/Kconfig" >>> >>> +source "arch/arm/cpu/armv7/am33xx/Kconfig" >>> + >>> source "arch/arm/mach-orion5x/Kconfig" >>> >>> source "arch/arm/cpu/armv7/rmobile/Kconfig" >>> diff --git a/arch/arm/cpu/armv7/am33xx/Kconfig b/arch/arm/cpu/armv7/am33xx/Kconfig >>> index 39759cd..dc51e9b 100644 >>> --- a/arch/arm/cpu/armv7/am33xx/Kconfig >>> +++ b/arch/arm/cpu/armv7/am33xx/Kconfig >>> @@ -1,3 +1,15 @@ >>> +if AM43XX >> >> AM43XX in am33xx/Kconfig? This seems bogus to me. > > See initial comment.. Thanks! bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany