From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yang, Wenyou Date: Wed, 4 May 2016 15:29:11 +0800 Subject: [U-Boot] [PATCH 07/18] net: macb: Convert to driver model In-Reply-To: <572858FE.1020501@denx.de> References: <1462257612-28746-1-git-send-email-sjg@chromium.org> <1462257612-28746-8-git-send-email-sjg@chromium.org> <572858FE.1020501@denx.de> Message-ID: <5729A4C7.8060101@atmel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 2016/5/3 15:53, Heiko Schocher wrote: > Hello Simon, > > Am 03.05.2016 um 08:40 schrieb Simon Glass: >> Add driver-model support to this driver. The old code remains for now so >> that we can convert boards one at a time. >> >> Signed-off-by: Simon Glass >> --- >> >> drivers/net/macb.c | 119 >> +++++++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 119 insertions(+) > > Thanks! > > Reviewed-by: Heiko Schocher > > tested on the smartweb, corvus, taurus and axm board > > Tested-by: Heiko Schocher I tried to test this patch series on SAMA5D2 Xplained board, but I have the following compile warning , did you experience it. ----8<----------- drivers/net/macb.c: In function 'macb_phy_init': drivers/net/macb.c:487:9: warning: passing argument 3 of 'phy_connect' from incompatible pointer type [enabled by default] In file included from include/miiphy.h:22:0, from drivers/net/macb.c:36: include/phy.h:226:20: note: expected 'struct udevice *' but argument is of type 'const struct device **' --->8---------------- > > bye, > Heiko Best Regards, Wenyou Yang