From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Wed, 4 May 2016 11:00:28 +0200 Subject: [U-Boot] [PATCH V2 1/2] mtd: cqspi: Simplify indirect write code In-Reply-To: <1462296357-5921-1-git-send-email-marex@denx.de> References: <1462296357-5921-1-git-send-email-marex@denx.de> Message-ID: <5729BA2C.2050902@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 03.05.2016 19:25, Marek Vasut wrote: > The indirect write code is buggy pile of nastiness which fails horribly > when the system runs fast enough to saturate the controller. The failure > results in some pages (256B) not being written to the flash. This can be > observed on systems which run with Dcache enabled and L2 cache enabled, > like the Altera SoCFPGA. > > This patch replaces the whole unmaintainable indirect write implementation > with the one from upcoming Linux CQSPI driver, which went through multiple > rounds of thorough review and testing. While this makes the patch look > terrifying and violates all best-practices of software development, all > the patch does is it plucks out duplicate ad-hoc code distributed across > the driver and replaces it with more compact code doing exactly the same > thing. > > Signed-off-by: Marek Vasut > Cc: Anatolij Gustschin > Cc: Chin Liang See > Cc: Dinh Nguyen > Cc: Jagan Teki > Cc: Pavel Machek > Cc: Stefan Roese > Cc: Vignesh R > --- > V2: Handle non-4-byte aligned transfers Reviewed-by: Stefan Roese Tested-by: Stefan Roese Thanks, Stefan