public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 2/2] mtd: cqspi: Simplify indirect read code
Date: Wed, 4 May 2016 11:00:46 +0200	[thread overview]
Message-ID: <5729BA3E.2010705@denx.de> (raw)
In-Reply-To: <1462296357-5921-2-git-send-email-marex@denx.de>

On 03.05.2016 19:25, Marek Vasut wrote:
> The indirect read code is a pile of nastiness. This patch replaces
> the whole unmaintainable indirect read implementation with the one
> from upcoming Linux CQSPI driver, which went through multiple rounds
> of thorough review and testing. All the patch does is it plucks out
> duplicate ad-hoc code distributed across the driver and replaces it
> with more compact code doing exactly the same thing. There is no
> speed change of the read operation.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Anatolij Gustschin <agust@denx.de>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> Cc: Jagan Teki <jteki@openedev.com>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Vignesh R <vigneshr@ti.com>
> ---
> V2: Handle non-4-byte aligned transfers

Reviewed-by: Stefan Roese <sr@denx.de>
Tested-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

  reply	other threads:[~2016-05-04  9:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-03 17:25 [U-Boot] [PATCH V2 1/2] mtd: cqspi: Simplify indirect write code Marek Vasut
2016-05-03 17:25 ` [U-Boot] [PATCH V2 2/2] mtd: cqspi: Simplify indirect read code Marek Vasut
2016-05-04  9:00   ` Stefan Roese [this message]
2016-05-04  9:00 ` [U-Boot] [PATCH V2 1/2] mtd: cqspi: Simplify indirect write code Stefan Roese
2016-05-04 19:04 ` Pavel Machek
2016-05-04 19:16   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5729BA3E.2010705@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox