From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Wed, 4 May 2016 11:08:22 -0600 Subject: [U-Boot] [PATCH 3/7] usb: dwc2: Throttle the setup packet resending In-Reply-To: <1462308680-9366-3-git-send-email-marex@denx.de> References: <1462308680-9366-1-git-send-email-marex@denx.de> <1462308680-9366-3-git-send-email-marex@denx.de> Message-ID: <572A2C86.7070604@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/03/2016 02:51 PM, Marek Vasut wrote: > Abort the request in case any of the tokens in the packet failed to > complete transfer 10 times. This is a precaution needed so that we > don't end in endless loop when scanning the bus with some braindead > devices. Does this affect USB keyboards when SYS_USB_EVENT_POLL_VIA_CONTROL_EP is enabled? IIRC control transactions to HID devices can be held off for some duration based on polling intervals, and this patch might abort them early? Or do we typically expect to use interrupt transfers for keyboards, so this isn't too relevant (although there are some platforms that enable SYS_USB_EVENT_POLL_VIA_CONTROL_EP). Maybe not DWC2 platforms though; I didn't check.