From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Wed, 4 May 2016 11:11:53 -0600 Subject: [U-Boot] [PATCH 7/7] usb: hub: Increase the query delay In-Reply-To: <1462308680-9366-7-git-send-email-marex@denx.de> References: <1462308680-9366-1-git-send-email-marex@denx.de> <1462308680-9366-7-git-send-email-marex@denx.de> Message-ID: <572A2D59.2080903@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/03/2016 02:51 PM, Marek Vasut wrote: > Increase the query delay, otherwise some sticks are not detected. > The problem shows up on the USB bus analyzer such that the stick > takes longer time to switch from FS mode to HS mode than the code > allows. > diff --git a/common/usb_hub.c b/common/usb_hub.c > @@ -145,7 +145,7 @@ static void usb_hub_power_on(struct usb_hub_device *hub) > * Do a minimum delay of the larger value of 100ms or pgood_delay > * so that the power can stablize before the devices are queried > */ > - hub->query_delay = get_timer(0) + max(100, (int)pgood_delay); > + hub->query_delay = get_timer(0) + max(1000, (int)pgood_delay); The comment right above that line of code should be updated to say 1000 not 100, and to mention why we're using the non-spec value.