public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] pci: tegra: fix DM conversion issues on Tegra20
Date: Wed, 4 May 2016 12:59:31 -0600	[thread overview]
Message-ID: <572A4693.9030100@wwwdotorg.org> (raw)
In-Reply-To: <1461188810-24083-1-git-send-email-swarren@wwwdotorg.org>

On 04/20/2016 03:46 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Tegra20's PCIe controller has a couple of quirks. There are workarounds in
> the driver for these, but they don't work after the DM conversion:
>
> 1) The PCI_CLASS value is wrong in HW.
>
> This is worked around in pci_tegra_read_config() by patching up the value
> read from that register. Pre-DM, the PCIe core always read this via a
> 16-bit access to the 16-bit offset 0xa. With DM, 32-bit accesses are used,
> so we need to check for offset 0x8 instead. Mask the offset value back to
> 32-bit alignment to make this work in all cases.
>
> 2) Accessing devices other than dev 1 causes a data abort.
>
> Pre-DM, this was worked around in pci_skip_dev(), which the PCIe core code
> called during enumeration while iterating over a bus. The DM PCIe core
> doesn't use this function. Instead, enhance tegra_pcie_conf_address() to
> validate the bdf being accessed, and refuse to access invalid devices.
> Since pci_skip_dev() isn't used, delete it.
>
> I've also validated that both these WARs are only needed for Tegra20, by
> testing on Tegra30/Cardhu and Tegra124/Jetson TKx. So, compile them in
> conditionally.
>
> Fixes: e81ca88451cf ("dm: tegra: pci: Convert tegra boards to driver model for PCI")
> Signed-off-by: Stephen Warren <swarren@nvidia.com>

TomW, I'd like to make sure this one gets into the upcoming release, 
since it's a functional bug-fix.

  parent reply	other threads:[~2016-05-04 18:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-20 21:46 [U-Boot] [PATCH] pci: tegra: fix DM conversion issues on Tegra20 Stephen Warren
2016-04-21  7:16 ` Thierry Reding
2016-04-27 15:12 ` Simon Glass
2016-05-04 18:59 ` Stephen Warren [this message]
2016-05-04 20:25   ` Tom Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=572A4693.9030100@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox