public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] test/py: fix NameError exception if bdi cmd is not supported
@ 2016-05-06  5:33 Heiko Schocher
  2016-05-06 15:25 ` Stephen Warren
  2016-05-30 17:56 ` [U-Boot] " Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Heiko Schocher @ 2016-05-06  5:33 UTC (permalink / raw)
  To: u-boot

test/py raises an error, if a board has not enabled bdi command

>           pytest.skip('bdinfo command not supported')
E           NameError: global name 'pytest' is not defined

import pytest in test/py/u_boot_utils.py fixes this.

Signed-off-by: Heiko Schocher <hs@denx.de>
---
found on the corvus board, which does not support this command.
For interests:
I integrated test/py into tbot, and catch test/py results, see
as a demo:
http://xeidos.ddns.net/tests/test_db_auslesen.php

 test/py/u_boot_utils.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/test/py/u_boot_utils.py b/test/py/u_boot_utils.py
index 72d24e4..1d7b12a 100644
--- a/test/py/u_boot_utils.py
+++ b/test/py/u_boot_utils.py
@@ -9,6 +9,7 @@ import os
 import os.path
 import sys
 import time
+import pytest
 
 def md5sum_data(data):
     """Calculate the MD5 hash of some data.
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] test/py: fix NameError exception if bdi cmd is not supported
  2016-05-06  5:33 [U-Boot] [PATCH] test/py: fix NameError exception if bdi cmd is not supported Heiko Schocher
@ 2016-05-06 15:25 ` Stephen Warren
  2016-05-30 17:56 ` [U-Boot] " Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Warren @ 2016-05-06 15:25 UTC (permalink / raw)
  To: u-boot

On 05/05/2016 11:33 PM, Heiko Schocher wrote:
> test/py raises an error, if a board has not enabled bdi command
>
>>            pytest.skip('bdinfo command not supported')
> E           NameError: global name 'pytest' is not defined
>
> import pytest in test/py/u_boot_utils.py fixes this.

Reviewed-by: Stephen Warren <swarren@nvidia.com>

Nit: The import statements were sorted before this patch.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] test/py: fix NameError exception if bdi cmd is not supported
  2016-05-06  5:33 [U-Boot] [PATCH] test/py: fix NameError exception if bdi cmd is not supported Heiko Schocher
  2016-05-06 15:25 ` Stephen Warren
@ 2016-05-30 17:56 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2016-05-30 17:56 UTC (permalink / raw)
  To: u-boot

On Fri, May 06, 2016 at 07:33:51AM +0200, Heiko Schocher wrote:

> test/py raises an error, if a board has not enabled bdi command
> 
> >           pytest.skip('bdinfo command not supported')
> E           NameError: global name 'pytest' is not defined
> 
> import pytest in test/py/u_boot_utils.py fixes this.
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Reviewed-by: Stephen Warren <swarren@nvidia.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160530/7a561731/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-05-30 17:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-06  5:33 [U-Boot] [PATCH] test/py: fix NameError exception if bdi cmd is not supported Heiko Schocher
2016-05-06 15:25 ` Stephen Warren
2016-05-30 17:56 ` [U-Boot] " Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox